[#16771] - Allow to use tinymce params
- Closed
- 10 May 2018
- Medium
- Build: staging
- # 16771
- Diff
- alex7r:tinymce-params
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Redo of #16387 to force travis to start
Summary of Changes
Allow to set tinymce parameters like
$options = array(
'inline'=>true,
'menubar'=>false,
);
echo $editor->display( 'new_incorrect_feed', '', 500, 170, '20', '10', true, null, null, null, $options )Testing Instructions
Pass options to the $editor, for example inline => true
Expected result
Tinymce is in inline mode.
Actual result
Tinymce is not in inline mode.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End Plugins |
Ok, now drone hangs XD
Warning is displayed above the editor when editing an article.
Notice: Undefined index: tinyMCE in C:\xampp\htdocs\joomla-cms\plugins\editors\tinymce\tinymce.php on line 202
Hm... It seems like the part responsible for that may be at $doc->getScriptOptions and not in changed code. But I'll check and fix, thanks for test.
A different error now with default install.
Notice: Undefined index: articletext in C:\xampp\htdocs\joomla-cms\plugins\editors\tinymce\tinymce.php on line 207
Sorry, were not able to get back to contribute to the repo in some time already. I'll try to update the branch in a few days.
wilsonge
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-10 21:23:14 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2018-05-10 21:23:14 | ⇒ | 2018-05-10 21:23:15 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/16771
Closing for now and can be opened if/when you have time.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16771.
@wilsonge
Just so you know that it's restarted.