? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 Jun 2017

Pull Request for Issue #16710

The name of the image files do not display in Isis Media Manager.

After patch, one should get in LTR

screen shot 2017-06-19 at 11 29 19

and in RTL
screen shot 2017-06-19 at 11 30 12

For RTL, as it was impossible to keep the magnifiying glass to the right and that anyway a file name should be LTR, I have put it to the left as in LTR. It is not an issue imho in that specific case to move it.

@bertmert @franz-wohlkoenig
Getting the image title in the Preview modal title is not easy. It requires some JS to append it.

avatar infograf768 infograf768 - open - 19 Jun 2017
avatar infograf768 infograf768 - change - 19 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2017
Category Administration Templates (admin)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Jun 2017

Can you screw on Visibility?
bildschirmfoto 2017-06-19 um 12 12 42

avatar infograf768
infograf768 - comment - 20 Jun 2017

Do you mean to get this?

screen shot 2017-06-20 at 08 00 32

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

@infograf768 yes, mean to read Filenames better.

avatar infograf768 infograf768 - change - 20 Jun 2017
Labels Added: ?
avatar infograf768
infograf768 - comment - 20 Jun 2017

Here it is. One should now get this:
screen shot 2017-06-20 at 11 45 01

Please test again.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

RTL (Persian): Should the Symbol be on right Side?
1

avatar infograf768
infograf768 - comment - 20 Jun 2017

RTL (Persian): Should the Symbol be on right Side?

Impossible. I spoke about that in my original description.

For RTL, as it was impossible to keep the magnifiying glass to the right and that anyway a file name should be LTR, I have put it to the left as in LTR. It is not an issue imho in that specific case to move it.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

I have tested this item successfully on 431263e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16769.

avatar Quy
Quy - comment - 20 Jun 2017

Text is on 2 lines.
headers

Text font size is larger than folder font size.
folders

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

@Quy which Browser, OS? I'm using Macos+Firefox, Result see Screenshot above.

avatar Quy
Quy - comment - 20 Jun 2017

Firefox 54.0 on Windows 10 Home

avatar Quy
Quy - comment - 20 Jun 2017

If there is a hyphen in the file name, then it will wrap 2 lines.

avatar infograf768
infograf768 - comment - 20 Jun 2017

I have added a nowrap class to solve the issue with the hyphen.
Please @Quy @franz-wohlkoenig
test again.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

I have tested this item successfully on bba284d

Test on MacOs Firefox, Chrome, Safari (all latest)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16769.

avatar Quy
Quy - comment - 20 Jun 2017

Will the folder text size be the same as the file text size?

avatar infograf768
infograf768 - comment - 20 Jun 2017

Changed file text size to match folder and extended truncate to 16 letters.

To get this:
screen shot 2017-06-20 at 16 13 03

avatar Quy
Quy - comment - 20 Jun 2017

Some text are touching the right edge.

edge

avatar Quy
Quy - comment - 20 Jun 2017

Here is another solution using the truncate class. Also, moved the text out of the span tag.

 		<div class="imgPreview nowrap small">
			<a href="<?php echo COM_MEDIA_BASEURL, '/', $img->path_relative; ?>" title="<?php echo $img->name; ?>" class="preview truncate">
				<span class="icon-search" aria-hidden="true"></span><?php echo $img->name; ?>
			</a>
		</div>

With your solution, there is room to display the g but it is truncated based on # of characters.
truncate

avatar infograf768
infograf768 - comment - 21 Jun 2017

Thanks @Quy. Done.

Don't forget to also test in rtl.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jun 2017

I have tested this item successfully on 9a93825

Test LTR and also in RTL (Persian).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16769.

avatar Quy
Quy - comment - 21 Jun 2017

Sorry to nitpick. See the arrow. The horizontal lines don't line up. The line in the file box is slightly higher than the one in the folder box.

after-border

avatar infograf768
infograf768 - comment - 21 Jun 2017

@Quy I guess we will survive with this.

avatar Quy Quy - test_item - 21 Jun 2017 - Tested successfully
avatar Quy
Quy - comment - 21 Jun 2017

I have tested this item successfully on 9a93825


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16769.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Jun 2017
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jun 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 21 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-21 18:21:20
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 21 Jun 2017
avatar rdeutz rdeutz - merge - 21 Jun 2017

Add a Comment

Login with GitHub to post a comment