?
avatar uzielweb
uzielweb
19 Jun 2017

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

the default_form.php have this unnecessary code in the line 25:

<?php if (isset($fieldset->label) && ($legend = trim(JText::_($fieldset->label))) !== '') : ?> <legend><?php echo $legend; ?></legend> <?php endif; ?>

Expected result

Legends title "Send a Form" is annoying and unnecessary (since Joomla 1.0)

Steps to reproduce the issue

in default.php have this unnecessary code in the line 113:

<?php elseif ($presentation_style === 'plain') : ?> <?php echo '<h3>' . JText::_('COM_CONTACT_EMAIL_FORM') . '</h3>'; ?>

Expected result

this h3 title in plain form is annoying and unnecessary (since Joomla 1.0)

avatar uzielweb uzielweb - open - 19 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Jun 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jun 2017
Category com_contact Feature Request
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Jun 2017

Thanks for Request. I guess a Language Override isn't a Solution?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16759.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jun 2017
Status New Discussion
avatar uzielweb
uzielweb - comment - 19 Jun 2017

I am using this solution: override the template code from com_contact/contact.
If the case is to maintain this feature I suggest to add an option to show/hide in the xml forms.

avatar uzielweb uzielweb - change - 19 Jun 2017
The description was changed
avatar uzielweb uzielweb - edited - 19 Jun 2017
avatar uzielweb uzielweb - change - 19 Jun 2017
The description was changed
avatar uzielweb uzielweb - edited - 19 Jun 2017
avatar uzielweb uzielweb - change - 19 Jun 2017
The description was changed
avatar uzielweb uzielweb - edited - 19 Jun 2017
avatar Bakual
Bakual - comment - 19 Jun 2017

The <legend> is fine imho. If you don't like it, there are two possible solutions beside creating an override.

  • Language string override: Create an override for COM_CONTACT_CONTACT_DEFAULT_LABEL and assign an empty value to it. The legend will no longer show.
  • CSS:
#contact-form legend {
    display: none;
}

As for the <h3>, we could add a CSS class to it, so it can be targetted with CSS and hidden if someones wants to. But removing it is imho wrong.

avatar brianteeman
brianteeman - comment - 3 Aug 2017

This is a matter of opinion and as it can be addressed in a template override I am closing this

avatar brianteeman brianteeman - change - 3 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-03 09:49:25
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Aug 2017

Add a Comment

Login with GitHub to post a comment