? Pending

User tests: Successful: Unsuccessful:

avatar mahagr
mahagr
16 Jun 2017

Pull Request for Issue #16720.

Summary of Changes

Fixed broken package update for child library when the manifest file of the package has: <blockChildUninstall>1</blockChildUninstall>

Testing Instructions

The issue can be reproduced on any package which uses the new Joomla 3.7 feature and contains a library in it. Here's one that I know of:

Installation should succeed without warnings and if you go to Extensions > Manage > Manage and filter by Gantry 5, you should see Gantry 5 Framework library entry only a single time.

Actual result

During second installation you will see a warning:

Warning
The Gantry 5 Framework extension is part of a package which does not allow individual extensions to be uninstalled.

When you visit Extensions > Manage > Manage, you will see the library installed 2 times. Every new install after this will add a new extension entry.

Documentation Changes Required

Maybe there's a need for instructions on how to fix broken database (release notes? known issues?). The easiest way to do that is to uninstall the package. After uninstalling the package, you can also uninstall all the extra extensions. Uninstalling will raise a warning, but it can be safely ignored.

avatar mahagr mahagr - open - 16 Jun 2017
avatar mahagr mahagr - change - 16 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2017
Category Libraries
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2017

Milestone: Due by June 27, 2017.

avatar Quy Quy - test_item - 17 Jun 2017 - Tested successfully
avatar Quy
Quy - comment - 17 Jun 2017

I have tested this item successfully on 8858612


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16729.

avatar richard67 richard67 - test_item - 18 Jun 2017 - Tested successfully
avatar richard67
richard67 - comment - 18 Jun 2017

I have tested this item successfully on 8858612


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16729.

avatar richard67
richard67 - comment - 18 Jun 2017

@franz-wohlkoenig RTC + milestone 3.7.3?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16729.

avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Jun 2017

RTC after two successful tests.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Jun 2017

@richard67 i have no Rights for Milestone.

avatar richard67
richard67 - comment - 18 Jun 2017

@rdeutz Milestone 3.7.3 ? It fixes a bug and does not have any language file change so no reason to wait.

avatar rdeutz rdeutz - change - 19 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-19 04:41:24
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Jun 2017
avatar rdeutz rdeutz - merge - 19 Jun 2017
avatar mahagr
mahagr - comment - 20 Jun 2017

Thanks! I really appreciate you being fast with this one!

Add a Comment

Login with GitHub to post a comment