[#16727] - Refer to "installation" folder instead of installation folder
- Closed
- 21 Jul 2017
- Medium
- Build: staging
- # 16727
- Diff
- Bakual:ClarifyInstallationFolder
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending continuous-integration/jenkins/pr-merge This commit is being built Details
User tests: Successful: Unsuccessful:
There seem to be some inconsistency in how we refer to the installation folder during installation.
Summary of Changes
This PR proposes to use folder "installation" instead installation folder.
Please note that this is based on my native language german where we would rather say Das Verzeichnis "Installation" instead of Das Installationsverzeichnis when we want to give weigth to the name of the folder. Installationsverzeichnis has a more generic meaning of "the directory where the installation is".
I really don't know if the same applies to english or if that just sounds awkward this way. So @brianteeman and other native speakers have to give their insight here.
Testing Instructions
Test that installation works and especially the language strings related to deleting the installation folder.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
So Remove "installation" folder would be better english than Remove folder "installation"?
to be honest though this is a complete waste of time as 50% of the translations still ignore the note not to translate the word installation and now they will still continue to do that but this time the translation will have "
Personally I don't think so. When I see Remove "installation" folder I would not translate it as "Installationsverzeichnis" in german. It gives more weigth to the name of the folder and then I have to say it different in german. Of course that assumes translators try to do the closest translation possible and just didn't see the existing comments (which they may or may not have seen).
I will update the PR later this day from home if nobody objects. Have to leave work now
while you continue to knowingly bad translations it really doesnt matter at all - its a waste of everyones time
Hmm, if only there were a platform where translators were encouraged to collaborate on instead of doing whatever they please...
Huh? I don't do any translations at all. I try to support the translators in doing their work.
And I merge what I am given by the translators if you refer to installation and some other files.
good idea to add the quotes.
i used single quotes for french btw
https://github.com/joomla/joomla-cms/blob/staging/installation/language/fr-FR/fr-FR.ini#L123
| Labels |
Added:
?
?
|
||
Moved 'installation' back before "folder" and use single quotes over double quotes (makes language files a bit simpler).
Reminder to maintainer: Due to language freeze, this can't be merged for 3.7.3.
| Milestone |
Added: |
||
| Title |
|
||||||
| Title |
|
||||||
Your optimism is overwhelming
next one @chrisdavenport
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
As proven today there is no point in doing this. Translators are still translating the word installation even with quotes and the translation coordinators still accept and knowingly merge incorrect translations
Closing. Until we fix the workflow and political problems surrounding the core translation teams, let's not waste anyone else's time.
@Bakual @infograf768 I want to meet with you two and MIG at some point, and want one of you at our next department meeting.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-21 12:50:34 |
| Closed_By | ⇒ | mbabker |
the changes to the order of the words is not correct english. adding the " is ok english,.
to be honest though this is a complete waste of time as 50% of the translations still ignore the note not to translate the word installation and now they will still continue to do that but this time the translation will have "