? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
16 Jun 2017

Based on the current valid upgrade policy which says an upgrade to 4.0 is only supported from 3.9.

Summary of Changes

  • Removes all SQL files that are not related to 4.0
  • Removes code in the script.php file which can be assumed to have run in 3.9.0.

Testing Instructions

Could be tested by upgrading from 3.7 to 4.0. But I haven't tried if that even works yet. Most likely it's broken without this PR already ?
Other than that it is code review.

avatar Bakual Bakual - open - 16 Jun 2017
avatar Bakual Bakual - change - 16 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2017
Category Administration com_admin SQL
avatar wilsonge
wilsonge - comment - 16 Jun 2017

Few things

  1. Yup we haven't tried to get the upgrades working yet so it will almost certainly fail :) (if nothing else because we aren't removing all the old files we're deleting yet)
  2. What happens to the Database Fixer tool with the SQL files gone? I mean for sure it's not an upgrade path we support but unsure if the fixer tool is usable without it? It would at least mean people would be forced to run the fixer before they upgrade from 3.9 to 4
  3. Everything in script.php looks good :)
avatar Bakual
Bakual - comment - 16 Jun 2017

What happens to the Database Fixer tool with the SQL files gone? I mean for sure it's not an upgrade path we support but unsure if the fixer tool is usable without it? It would at least mean people would be forced to run the fixer before they upgrade from 3.9 to 4

It would only apply SQL files from 4.0 onwards, and yes it would mean people have their site up to date prior to the upgrade.
Do you think we can't assume people have a working installation before they upgrade?
Maybe we can add a check to the Joomla Update component which shows a warning if the fixer detects an issue to prevent people accidentally upgrading a broken installation?

Imho it's a step we have to take eventually anyway. We have files going back to 2.5.0 in 2011 there...

avatar zero-24
zero-24 - comment - 16 Jun 2017

Is there a reason we do not support updates from 3.8.last to 4.0? As 3.9 and 4.0 are currently planed to be released at the same time?

avatar mbabker
mbabker - comment - 16 Jun 2017

From a practical perspective, it probably won't be much different unless we remove something from the deleted files/folders list that gets removed between 3.8 and 3.9 and inherently wouldn't be in 4.0. As a matter of policy though, let's keep the main focus on 3.last to 4.0 then take into consideration supporting additional releases as practical.

avatar wilsonge
wilsonge - comment - 29 Jun 2017

Can you fix conflicts and I'll get this merged :)

avatar Bakual
Bakual - comment - 29 Jun 2017

Rebased and conflicts solved.

avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar brianteeman
brianteeman - comment - 24 Jul 2017

@wilsonge reminder to merge this

avatar wilsonge wilsonge - change - 24 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-24 14:20:50
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Jul 2017
avatar wilsonge wilsonge - merge - 24 Jul 2017
avatar wilsonge
wilsonge - comment - 24 Jul 2017

Thanks for the reminder :)

Thanks @Bakual :)

Add a Comment

Login with GitHub to post a comment