[#16721] - resolve category field change event issue for calendar fields in Persian language
- Closed
- 4 Sep 2017
- Medium
- Build: staging
- # 16721
- Diff
- farzadtaheri:staging
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Problem: com_fields category fields change event causing problem in Persian fa-IR.
with this change, all calendars fields with localized data type (like Jalali) are converted to standard date type and then submit form.
Pull Request for Issue #16628 .
Summary of Changes
replace line 350 and change this code:
element.form.submit();
to
Joomla.submitform('field.storeform', element.form);
Testing Instructions
1- make sure you have more than two category for articles(com_content)
2- make sure you have at least a field for articles with context: com_content.article in com_fields
3- change back-end language to Persian(fa-IR).
4- go to Content > Articles. in Persian language the path is: محتوا > مطالب
5- edit an article and change category field value to another one.
Expected result
before this change:
after change category field value you see an error: DateTime::__construct(): Failed to parse time string (۱۳۹۶-۰۳-۰۶ ۰۳:۳۶:۰۲) at position 0 (�): Unexpected character
after change code and replace line 350 with new one:
dont show any error and fully reload page after ajax call
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
If i follow the test instructions and the patch is applied i get the following warning, after changing the category of the articel:
خصوصیات افزونه برای فیلد مجموعه خالی است
Google told me that it means something like a missing argument. The changes of the artikel are not safed and the field overview(content>>Fields) is shown. Without the patch it works fine.
Although no DatTime__-Error occours anymore.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16721.
You need to update your branch to fix the conflicts.
@farzadtaheri if #17859 replace this PR please close it.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-04 07:49:48 |
| Closed_By | ⇒ | farzadtaheri |
This will conflict with #16665 as we are dealing with a time shift issue.