[#16716] - [ libraries / joomla] Type-safe comparisons #4
- Closed
- 16 Jun 2017
- Medium
- Build: staging
- # 16716
- Diff
- frankmayer:libraries-joomla-type-safety-4
User tests: Successful: Unsuccessful:
Summary of Changes
Implemented type-safe comparisons in the libraries / joomla directory.
For easier reviewing, there is a total of five parts, that cover the libraries / joomla directory
This is part 4, which covers directories github until input
Testing Instructions
Code review only, as those changes should not affect behavior.
Despite the quantity of the changes, it should be fairly easy to review.
Attention to code reviewers:
In order to prevent code-review-fatigue, I only did type safe comparisons, without applying:
- formatting
- removal of unnecessary parentheses
- other non-related changes
Please only review the correctness of the specific changes, without pointing out any possible formatting issues (unless corrupted by this PR), removal of parentheses and other non-related changes. This will help get this PR reviewed and merged quickly.
If you should find other prospects for type safe comparison in those folders please note them in a review.
Thank you
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Repository |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-16 09:42:24 |
| Closed_By | ⇒ | frankmayer |
Closing this set of PR's in favor of opening a new one against 3.8-dev (or 4.0?). We'll see.