[#16704] - [4.0] Database Fixer unexpected removes files
- Closed
- 16 Jun 2017
- Medium
- Build: staging
- # 16704
Steps to reproduce the issue
- On a 4.0 installation, click the database fix button in Extensions -> Manage -> Database.
- Check Git for removed files
Expected result
- administrator/manifests/packages/pkg_weblinks.xml is removed
Actual result
Additionally removed files:
- administrator/components/com_languages/layouts/joomla/searchtools/default.php
- administrator/components/com_media/models/forms/file.xml
- media/com_banners/js/admin-banner-edit.js
- media/com_finder/js/finder.js
- media/editors/codemirror/css/codemirror.css
Additional comments
I'm not sure why they get removed. Those are files which are present in GitHub so I would not expect them to be removed (or they should be removed from GitHub).
The Weblinks one is a known exception due to the way we decoupled it. We could probably remove it from GitHub in 4.0.
joomla-cms-bot
- | Labels |
Added:
?
|
||
That's true for the translation files, the package file however was another reason to my knowledge. That file wasn't present prior to the decoupling and we had to add it so weblinks is a real package. The fixer removes it when weblinks isn't installed. If we only allow to upgrade to 4.0 from versions after weblinks is decoupled, then we no longer need it.
Whatever is in the com_admin upgrade script's deleted files/folders arrays is what's getting removed. If that's not right for whatever reason then that's the place to fix it.
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | Administration |
I'll try to figure out why they ended up in there then and fix it. Probably tomorrow
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-16 11:14:55 |
| Closed_By | ⇒ | Bakual |