[#16656] - [4.0] Array to php 5.4+ notation [Plugins 5: System]
- Closed
- 13 Jun 2017
- Medium
- Build: 4.0-dev
- # 16656
- Diff
- andrepereiradasilva:array-54-plugins-5
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
Since 4.0 doesn't support php 5.3 anymore, use php 5.4+ array notation in System plugins.
Testing Instructions
Simple code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
The same question popped up in my mind.
I think it is more a question of code style beside the fact we save 5 bytes :-)
So do we have a new codestyle rule for using short array syntax?
Otherwise I would say to not merge those PRs because they just will create conflicts and not improve anything.
So do we have a new codestyle rule for using short array syntax?
Not that I know.
Or merge them, after the 4.0-dev branch got merged into staging.
@andrepereiradasilva could you open an issue here: https://github.com/joomla/coding-standards so we can discuss the change and then move forward whatever the decision will be
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 13:24:55 |
| Closed_By | ⇒ | andrepereiradasilva |
Asking stupid, is there any reason for this change beside that it is possible now?
Eg is it faster this way?