[#16630] - [4.0] Adding a.modified to the association group_by
- Fixed in Code Base
- 12 Jun 2017
- Medium
- Build: 4.0-dev
- # 16630
- Diff
- Bakual:FixArticlesModelAssociationGroup
User tests: Successful: Unsuccessful:
On a multilingual site, when associations are enabled, the articles model will throw an error because the group_by clause doesn't contain all selected columns. Which is a requirement in MySQL strict mode.
Summary of Changes
Adds the missing a.modified column to the group
Testing Instructions
- Make sure you have at least two languages installed (french should work) and associations are enabled
- Try accessing the articles manager
Expected result
Article list
Actual result
Error page
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
i'll check for postgresql in 3.7.x staging , but i suspect for MSsql too
Thanks! This PR is clearly fine. Just want to check if it needs to go via staging
I guess no use in staging as no strict sql
I guess no use in staging as no strict sql
The thing is that PostgreSQL always uses strict. So George is right that this fix should go into staging instead. However looking at the respective code at https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/articles.php#L206, this column isn't the only one missing there
I know. That's one reason why Joomla on PostgreSQL most likely is broken badly.
tested as per test instruction
on a fresh postgresql latest staging (3.7.x) multilanguage 3(it,fr,gb)
however articles manager seems to works fine to me
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-12 18:39:10 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
If not required for 3.x all good by me!
The wonders of databases we don't have to understand
@csthomas or @alikon can you check if this is required for postgres in staging? I know mysql strict and postgres have similar requirements