[#16627] - Fix for #11070 (tag-category) - Improve also views newsfeed-category …
- Fixed in Code Base
- 25 Mar 2018
- Medium
- Build: staging
- # 16627
- Diff
- rvbgnu:fix_#11070
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
…and category-list
Pull Request for Issue #11070.
Summary of Changes
There is a width issue on the filter-search field. Especially for the tag view, where there are two buttons beside the field. The other filters usually have no button. This is the case for newsfeed-category and category-list.
The width comes from the general rule here:
input,
textarea,
.uneditable-input {
width: 206px;
}
https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/css/template.css#L936
Testing Instructions
» Go to the front-end with latest joomlacms (Test website using the Sample Data TEST to more views).
» In the Menu All Front End Views, click on Tagged items
» View on small device screen
» Repeat with Article Category List and News Feed Category menu items
Expected result
» Filter search is inside the container, and the select limit drop-down gracefully displays on the next line with a margin.
(Test website using the Sample Data TEST to more views).
Tag-category AFTER:
Category-list AFTER:
Newsfeed-category AFTER:
Actual result
The filter search and the buttons are a bit outside the container on a small device.
On Mac Firefox/Chrome, the issue is there until 328px wide. Fixed above.
Tag-category BEFORE:
Category-list BEFORE:
Newsfeed-category BEFORE:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
@kalpeshtailored can you please test?
Please don't edit the css directly. You should edit the less file and run generatecss.php
Oops, sorry @brianteeman , I will edit the PR and create separate ones for the other view, thanks @franz-wohlkoenig !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
It would be better as just a single pr
| Category | Front End Templates (site) | ⇒ | Administration Templates (admin) Front End Templates (site) |
Now .LESS file added, and better description for the three views concerned.
Generatecss.php also modified isis .css, but not used (filter-search is spelled filter_search)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
@kalpeshtailored please test this PR if it solves your reported Issue #11070.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
@kalpeshtailored @killoltailored please test so we get needed second Test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
I have tested this item
Result is like in the instruction.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16627.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-25 15:03:58 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I'm doing some frontend design, but I am not an expert.
If a UX or template designer could look and finding a better way, that will help ;-)