? Failure

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
9 Jun 2017

Pull Request for Issue # .

Summary of Changes

Broad RTL styling for the Atum backend template.

  • General RTL changes
  • Moved sidebar to right
  • Flipped main navigation
  • Flipped status bar
  • Flipped quick icons
  • Removed directional bootstrap classes
  • Removed floats from table
  • Refactored dashboard modules to allow RTL

Testing Instructions

Apply patch and log in to admin with RTL language (eg. Arabic).

Edit: Can also be tested without having to install an RTL language. See.. #16593 (comment)

Expected result

rtl1

rtl2

rtl3

Documentation Changes Required

Screenshots

avatar ciar4n ciar4n - open - 9 Jun 2017
avatar ciar4n ciar4n - change - 9 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2017
Category Administration com_banners com_contact com_content com_fields com_modules com_newsfeeds Modules Templates (admin) Layout
avatar brianteeman
brianteeman - comment - 9 Jun 2017

For people testing you do not need to install a new language. You may find it easier to test in your own language and you can do this easily

For example to change en-GB to RTL you need to edit the administrator/languages/en-GB/en-GB.xml file and change

  <rtl>0</rtl>

to

  <rtl>1</rtl>
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Jun 2017

I have tested this item ? unsuccessfully on 3514000

Not sure if:
bildschirmfoto 2017-06-09 um 11 36 46
or
bildschirmfoto 2017-06-09 um 11 37 58
is now to be tested.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16593.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Jun 2017 - Tested unsuccessfully
avatar ciar4n ciar4n - change - 9 Jun 2017
The description was changed
avatar ciar4n ciar4n - edited - 9 Jun 2017
avatar ciar4n ciar4n - change - 9 Jun 2017
The description was changed
avatar ciar4n ciar4n - edited - 9 Jun 2017
avatar ciar4n ciar4n - change - 9 Jun 2017
The description was changed
avatar ciar4n ciar4n - edited - 9 Jun 2017
avatar ciar4n
ciar4n - comment - 9 Jun 2017

Thank you @franz-wohlkoenig. Yes such issues can be reported here and I will amend them the next chance I get.

avatar ciar4n ciar4n - change - 10 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jun 2017
Category Administration com_banners com_contact com_content com_fields com_modules com_newsfeeds Modules Templates (admin) Layout Administration com_banners com_contact com_content com_fields com_modules com_newsfeeds Modules Templates (admin) Layout Front End Templates (site)
avatar ciar4n
ciar4n - comment - 10 Jun 2017

@franz-wohlkoenig Alerts and labels now fixed

avatar ciar4n ciar4n - change - 10 Jun 2017
The description was changed
avatar ciar4n ciar4n - edited - 10 Jun 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Jun 2017

@ciar4n thanks, will test more this Weekend.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Jun 2017

@ciar4n:
This is also in LTR:
bildschirmfoto 2017-06-10 um 08 50 59
missing Space:
bildschirmfoto 2017-06-10 um 08 53 46

avatar ciar4n
ciar4n - comment - 11 Jun 2017

@franz-wohlkoenig Btn-group (missing space) has been fixed.

Issues also present in LTR I will leave for a separate PR. Maybe just create a issue so we don't forget.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jun 2017

Fix looks fine.

#16620

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jun 2017

Text align right:
bildschirmfoto 2017-06-12 um 09 30 25

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jun 2017

Point at Beginning of Sentence?
1

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jun 2017

1

avatar ciar4n
ciar4n - comment - 13 Jun 2017

Text align right:

Fixed

Point at Beginning of Sentence?

If I am not mistaken this is correct RTL behaviour

The media manager can be ignored for now. I will do the RTL for that separately

avatar brianteeman
brianteeman - comment - 13 Jun 2017

Point at Beginning of Sentence?
If I am not mistaken this is correct RTL behaviour

RTL gets very funky when you have LTR text in it - especially punctuation.. Dont worry about that for now it should be fine when using an RTL language and font

avatar wilsonge
wilsonge - comment - 15 Jun 2017

I'm going to merge this as a starting point before it starts accumulating conflicts. I'm sure there's going to be a lot more to do though :)

avatar wilsonge wilsonge - change - 15 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-15 15:46:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Jun 2017
avatar wilsonge wilsonge - merge - 15 Jun 2017

Add a Comment

Login with GitHub to post a comment