[#16583] - put multiple versions of the same tag
- Fixed in Code Base
- 19 Jul 2017
- Medium
- Build: staging
- # 16583
- Diff
- sitevtule:multiple-meta-tag
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Changed the type of the parameter $content from a string to an array in the setMetaData method of the JDocument class.
This will allow you to add multiple identical tags with different values. For example og:image (http://ogp.me/#array)
Testing Instructions
Call in your code
JFactory::getDocument()->setMetaData("og:image", array("/image1.jpg", "/image2.jpg", "/image3.jpg"), 'property');
Expected result
View the source of the page in the browser.
You should see the following code in head:
<meta property="og:image" content="/image1.jpg" /> <meta property="og:image" content="/image2.jpg" /> <meta property="og:image" content="/image3.jpg" />
Documentation Changes Required
https://api.joomla.org/cms-3/classes/JDocument.html#method_setMetaData
Replace this:
$content string Value of the meta HTML tag
with this:
$content mixed Value of the meta HTML tag as array or string
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
@franz-wohlkoenig oops! Sory
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583.
@franz-wohlkoenig Please RTC as the last change was to remove tabs which would not affect the test result. Thanks.
| Status | Pending | ⇒ | Ready to Commit |
| Title |
|
||||||
RTC after two successful tests.
zero-24
- | Milestone |
Added: |
||
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-19 12:15:53 |
| Closed_By | ⇒ | mbabker |
@kernusr can you please write the "Summary of Changes" also in English – thanks.