[#16561] - [4.0] proper strings for media manager
- Fixed in Code Base
- 8 Jun 2017
- Medium
- Build: 4.0-dev
- # 16561
- Diff
- dgt41:###############4.0-dev-com_media_langs
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Bring back the missing strings
Testing Instructions
Apply patch, check com_media's options
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16561.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16561.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16561.
I have tested this item
reverting my successful test as this string is still missing
COM_MEDIA_CONFIGURATION="Media: Options"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16561.
Please remove RTC for now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16561.
| Labels |
Added:
?
|
||
@brianteeman just added it back, is there anything else missing here?
Thanks for that one. As for other strings I have no idea because it is completely unfunctional so I can't use it to see
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-08 10:53:15 |
| Closed_By | ⇒ | wilsonge |
What do you mean by unfunctional?
@wilsonge all i see is this screenshot and no buttons are functional
and the following js error in the console
Uncaught TypeError: Cannot read property 'filter' of undefined
at Api._normalizeArray (mediamanager.js:8763)
at Object.<anonymous> (mediamanager.js:8633)
at i (jquery.min.js:2)
at Object.fireWith [as resolveWith] (jquery.min.js:2)
at A (jquery.min.js:4)
at XMLHttpRequest.<anonymous> (jquery.min.js:4)
Did you do a fresh install? If not then you need to discover the new media manager plugins.
Did you do a fresh install? If not then you need to discover the new media manager plugins.
I can confirm that after discovering and enabling the plugins the console errors are gone.
I opened a new issue about that as I think the UX needs to be improved here.
the plugins were already enabled - it was a new install
On a fresh installed 4.0-dev explored Plugins and activate them:
got this, seems fine:
@laoneo do you want to get in touch with @brianteeman and try and work this through as it would appear to be something specific to his setup?
I asked in the j4 geoup if somebody with a windows environment can have a look as I can't repeoduce the issue.
I just installed latest 4.0-dev and it works OK. Tried to navigate between folder, create folder, upload images... and it works (just a quick try only)
I also don't see any error in the console. Look like it works fine. I am using Windows 8.
I think it is related somehow to the special setup Brian has. It is a "real" Windows server, not the wanna-be XAMPP type one we usually test on :)
Which is even more reason to try and work out what the issue is. It might be an apache or php module that needs to be enabled. If that is the case then it needs to be added to the requirements etc
I have tested this item✅ successfully on 386d901
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16561.