? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
7 Jun 2017

Pull Request for Issue #16127 .

Summary of Changes

added join when order by field u.name

Testing Instructions

#16127 (comment)

  • content navigation work as before

Expected result

no error

Actual result

sql error

Documentation Changes Required

avatar alikon alikon - open - 7 Jun 2017
avatar alikon alikon - change - 7 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2017
Category Front End Plugins
avatar alikon alikon - change - 7 Jun 2017
The description was changed
avatar alikon alikon - edited - 7 Jun 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

will test Today.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

I have tested this item successfully on 2c50de4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16556.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Jun 2017 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Jun 2017

hi @alikon but that means you will not order by Author (created by alias many times can be empty).
image

I think the right solution is: if ordering by author, join the users table also.

avatar brianteeman
brianteeman - comment - 7 Jun 2017

This change is not correct. It will only work if an alias is set.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16556.

avatar brianteeman
brianteeman - comment - 7 Jun 2017

I have tested this item ? unsuccessfully on 2c50de4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16556.

avatar brianteeman brianteeman - test_item - 7 Jun 2017 - Tested unsuccessfully
avatar richard67
richard67 - comment - 7 Jun 2017

I agree with @andrepereiradasilva : If ordering by author, join the users table also.

avatar alikon
alikon - comment - 8 Jun 2017

oops still in holiday ? , i'll add the join with the users table when needed

avatar alikon
alikon - comment - 14 Jun 2017

ready to test

avatar infograf768
infograf768 - comment - 14 Jun 2017

I have tested this item successfully on 6be3a60

Here I was getting this error before patch:

[14-Jun-2017 06:49:43 UTC] PHP Notice:  Undefined variable: previousExceptionHandler in /Applications/MAMP/htdocs/testwindows/trunkgitnew/plugins/system/redirect/redirect.php on line 112
[14-Jun-2017 06:49:43 UTC] PHP Stack trace:
[14-Jun-2017 06:49:43 UTC] PHP   1. PlgSystemRedirect::handleException() /Applications/MAMP/htdocs/testwindows/trunkgitnew/plugins/system/redirect/redirect.php:0
[14-Jun-2017 06:49:43 UTC] PHP   2. PlgSystemRedirect::doErrorHandling() /Applications/MAMP/htdocs/testwindows/trunkgitnew/plugins/system/redirect/redirect.php:91
[14-Jun-2017 06:49:43 UTC] PHP Fatal error:  Function name must be a string in /Applications/MAMP/htdocs/testwindows/trunkgitnew/plugins/system/redirect/redirect.php on line 112
[14-Jun-2017 06:49:43 UTC] PHP Stack trace:
[14-Jun-2017 06:49:43 UTC] PHP   1. PlgSystemRedirect::handleException() /Applications/MAMP/htdocs/testwindows/trunkgitnew/plugins/system/redirect/redirect.php:0
[14-Jun-2017 06:49:43 UTC] PHP   2. PlgSystemRedirect::doErrorHandling() /Applications/MAMP/htdocs/testwindows/trunkgitnew/plugins/system/redirect/redirect.php:91

This PR solves it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16556.

avatar infograf768 infograf768 - test_item - 14 Jun 2017 - Tested successfully
avatar alikon alikon - change - 14 Jun 2017
The description was changed
avatar alikon alikon - edited - 14 Jun 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2017

I have tested this item successfully on 6be3a60


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16556.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 21 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-21 18:28:35
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 21 Jun 2017
avatar rdeutz rdeutz - merge - 21 Jun 2017

Add a Comment

Login with GitHub to post a comment