Feeling Lucky
?
[#16549] - [4.0] Equal widths across header icons
- Fixed in Code Base
- 18 Jun 2017
- Medium
- Build: 4.0-dev
- # 16549
- Diff
- ciar4n:header-icons
- Error hound Error parsing config for: scss. Click "details" for assistance. Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Gives the top right header icons equal widths.
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
ciar4n
- comment
- 7 Jun 2017
If it's just the icons themselves that needs to be fixed with, then you can use the fa-fw class, e.g:
Won't work as it would be overruled by https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/blocks/_header.scss#L68
Inline with what you suggest I have moved the width to the icon level
brianteeman
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
N6REJ
- comment
- 18 Jun 2017
what is a "fa" class and where is it documented?
ciar4n
- comment
- 18 Jun 2017
fa is a FontAwesome class which is the icon library been used for Joomla 4... http://fontawesome.io/
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-18 14:28:31 |
| Closed_By | ⇒ | wilsonge |
If it's just the icons themselves that needs to be fixed with, then you can use the
fa-fwclass, e.g:fa fa-external-link fa-fwWould be a nicer approach IMO