Feeling Lucky
?
[#16531] - Remove (int) since value is filtered already
- Fixed in Code Base
- 8 Jun 2017
- Medium
- Build: staging
- # 16531
- Diff
- nvyush:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Simple remove (int) since value of $Itemid is filtered already by getInt(). If set default value to 0, then $app->input->getInt('Itemid', 0) never returns other than int, so explicit type conversion is not necessary.
Testing Instructions
Code review.
Expected result
Actual result
Documentation Changes Required
Not needed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Quy
- comment
- 6 Jun 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16531.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 6 Jun 2017
RTC after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-08 12:06:06 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on ea044b1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16531.