Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16526] - Remove space from ID attribute on "Tel" field

? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
4 Jun 2017

Pull Request for Issue #16523

Summary of Changes

Remove the space from the ID attribute

Testing instructions

code review

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00
avatar C-Lodder C-Lodder - open - 4 Jun 2017
avatar C-Lodder C-Lodder - change - 4 Jun 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2017
Category ⇒ Layout
avatar Quy
Quy - comment - 4 Jun 2017

I have tested this item ✅ successfully on c5c5ab3

Space removed. In the page source, output wise, it now expands many lines.

<input
	type="tel"
	name="jform[telephone]"
	id="jform_telephone"
	value="abcd"
		size="30"          />
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16526.
avatar Quy Quy - test_item - 4 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Jun 2017

@fdesanto can you please test?

avatar wojsmol
wojsmol - comment - 4 Jun 2017

@C-Lodder Plese update test.

avatar C-Lodder
C-Lodder - comment - 4 Jun 2017

Sure. Will do when Im home

avatar C-Lodder C-Lodder - change - 5 Jun 2017
Labels Added: ?
avatar C-Lodder C-Lodder - change - 5 Jun 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 5 Jun 2017
avatar C-Lodder
C-Lodder - comment - 5 Jun 2017

updated the PR to only remove the space from the ID attribute

avatar kolvar
kolvar - comment - 7 Jun 2017

works as described

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16526.

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 7 Jun 2017 - kolvar: Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

@kolvar i altered your Test as successfully.
@Quy can you please retest?

avatar Quy
Quy - comment - 7 Jun 2017

I have tested this item ✅ successfully on 6b7a531

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16526.

avatar Quy Quy - test_item - 7 Jun 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Jun 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 9 Jun 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-06-09 20:48:22
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 9 Jun 2017
avatar rdeutz rdeutz - merge - 9 Jun 2017

Add a Comment

Login with GitHub to post a comment