[#16513] - Add correct path for language css [fix for 16506]
- Fixed in Code Base
- 6 Jun 2017
- Medium
- Build: staging
- # 16513
- Diff
- andrepereiradasilva:lang-css
User tests: Successful: Unsuccessful:
Pull Request for Issue #16506.
Summary of Changes
Sin 3.7.0 admin template does not load language specific css.
This PR intends to solve that.
Testing Instructions
- Use latest staging
- Add a en-GB.css file in
/administrator/language/en-GB/en-GB.css - Load the admin in isis and hathor and confirm the css file is loaded.
Expected result
Language specific CSS file is loaded.
Actual result
Language specific CSS file is not loaded.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I had solved it here with
JHtml::_('stylesheet', 'administrator/language/' . $lang->getTag() . '/' . $lang->getTag() . '.css', array('version' => 'auto'));
because the case is not taken care of in the includeRelativeFiles method
.../libraries/cms/html/html.php
where it defaults to $path = JPATH_ROOT . "/$file";
Will now test this PR
Sorry, this patch does not work for me.
@infograf768 ltrim($this->baseurl, '/') in administrator tempaltes is administrator so is the same as you have done but without hardcoding administrator.
It worked in my case can you explain better where it doesn't work?
I have no idea why it does not work here on Firefox. It works OK on Safari.
I know that with my solution I do get the correct href in source in both browsers
<link href="/testnew/trunkgitnew/administrator/language/fa-IR/fa-IR.css?1558dc3b794518a5caee794b66aaf3f0" rel="stylesheet" />
for info $this->baseurl here gives
/testnew/trunkgitnew/administrator
Hmm, maybe a session issue. After quit and reload Firefox, it is OK
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.
On my local install, where Joomla is in joomla-cms directory:
Not working with PR: joomla-cms/administrator/language/en-GB/en-GB.css
I think it is looking for joomla-cms inside joomla-cms.
Working with manual change and no relative: administrator/language/en-GB/en-GB.css
| Status | Ready to Commit | ⇒ | Pending |
i take of the rtc for now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.
| Labels |
Added:
?
|
||
should work now
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.
| Status | Pending | ⇒ | Ready to Commit |
RTC for good now. :)
@C-Lodder
Please use this code in 4.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.
Cheers. Will update tomorrow
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-06 19:36:13 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 4780f21
All good. Will do the same for 4.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16513.