[#16509] - Warn users that is not possible to use Shared session with Force HTTPS = Administrator Only
- Closed
- 4 Jun 2017
- Medium
- Build: staging
- # 16509
- Diff
- andrepereiradasilva:patch-26
User tests: Successful: Unsuccessful:
Pull Request for Issue #16485.
Summary of Changes
Adds a warning message when the used set the config to use "Shared Session" with "Force HTTPS" to "Administrator Only".
Testing Instructions
- Apply patch
- Set config "Shared Session" to "Yes" and "Force HTTPS" to "Administrator Only".
- Config saved but you get a warning telling that shared session will not work.
Expected result
Warn the user that shared sessions will nto work with current configuration.
Actual result
None.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings |
| Labels |
Added:
?
?
|
||
@richard67 yes you're right will close this and just make a PR to add info to the shared session tooltip
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-04 12:00:40 |
| Closed_By | ⇒ | andrepereiradasilva |
@richard67 check #16514
@andrepereiradasilva Maybe you should also add some information to the COM_CONFIG_FIELD_FORCE_SSL_DESC text that when choosing "Administrator only", the "Shared Session" option will not work anymore ;-) But this would cause a merge conflict with the other PR you have open for the secure cookie info :-P
@andrepereiradasilva For me this PR does not work because when changing the "Shared Session" value and saving the config, I get logged out and so never will see any warning message. The tooltip of the "Shared Session" toggle clearly tells that, too. So maybe it would be sufficient just to change that tool tip text so it contains your warning in general? I tested on a 3.7.2, not on latest staging.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16509.