Feeling Lucky
?
?
[#16501] - Stream transport should enable verify_peer_name when possible
- Fixed in Code Base
- 23 Feb 2021
- Medium
- Build: staging
- # 16501
- Diff
- wilsonge:verify_peer_name
- Success hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Enables verify_peer_name for the stream driver (which ensures the ssl certificate matches the domain name being queried). This does default to true since it was introduced in PHP 5.6 - but let's be explicit!
Testing Required
Ensure the stream http driver continues to work as expected (with the additional "security" mechanism enabled)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
roland-d
- comment
- 9 Jul 2017
I have tested this item
Before the patch the SSL verification isn't explicitly set. After the patch the SSL verification is explicitly set and the request still works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16501.
wilsonge
- comment
- 17 Sep 2017
Thanks for the prod! All done :)
| Status | Pending | ⇒ | Ready to Commit |
HLeithner
- comment
- 5 Jan 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16501.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-23 18:05:24 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 23 Feb 2021
Thanks
@wilsonge Should we do the same for cURL or not?