? Pending

User tests: Successful: Unsuccessful:

avatar piotrmocko
piotrmocko
3 Jun 2017

JAB17 make it happen.

Summary of Changes

Allow to pass version of Joomla into the method which checks weather an update is compatible.
This changes are needed by Joomla Update component to tell if your extensions have a compatible update for Joomla version to which you are going to update or upgrade.

It is a task which we are implementing on JAB 2017 with @wilsonge

Testing Instructions

$update = new JUpdate();
$update->set('jversion.full', '3.7.2');
$update->set('jversion.dev_level', '2');
$update->loadFromXML('https://update.joomla.org/core/extensions/com_joomlaupdate.xml');
$download_url = $update->get('downloadurl');

Above update server has an update only for Joomla 3.6
so $download_url->_data is empty as there is no update for Joomla 3.7.2

When you will change
$update->set('jversion.full', '3.6.0');
$update->set('jversion.dev_level', '0');
then $download_url->_data will contain a download URL.

Expected result

Allow to check if there is an update for a specific version of Joomla

Actual result

It is possible to check if there is an update only for current version of Joomla.

Documentation Changes Required

None

avatar piotrmocko piotrmocko - open - 3 Jun 2017
avatar piotrmocko piotrmocko - change - 3 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2017
Category Libraries
avatar zero-24
zero-24 - comment - 3 Jun 2017

so it has to be possible to check if the update is compatible with another J! version.

hmm I don't get that point? Why do you want to do that? Can you answear the questions from the PR template? This could help testing and understanding. ;) Thanks

avatar piotrmocko piotrmocko - change - 4 Jun 2017
The description was changed
avatar piotrmocko piotrmocko - edited - 4 Jun 2017
avatar piotrmocko piotrmocko - change - 4 Jun 2017
Title
Allow to change J! version against which updates will be checked
JAB17 Allow to change J! version against which updates will be checked
avatar piotrmocko piotrmocko - edited - 4 Jun 2017
avatar piotrmocko piotrmocko - change - 4 Jun 2017
Labels Added: ?
avatar wilsonge
wilsonge - comment - 4 Jun 2017

hmm I don't get that point? Why do you want to do that? Can you answear the questions from the PR template? This could help testing and understanding. ;) Thanks

We want to adapt Joomla Update to check compatibility with the version of Joomla you are going to update to.

avatar wilsonge
wilsonge - comment - 4 Jun 2017

Merging on mine and @mbabker 's code review at JAB

avatar wilsonge wilsonge - change - 4 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-04 09:56:40
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Jun 2017
avatar wilsonge wilsonge - merge - 4 Jun 2017

Add a Comment

Login with GitHub to post a comment