[#16486] - Fixes merging off session data when using two browser tabs with two separate …
- Fixed in Code Base
- 12 Jun 2017
- Medium
- Build: staging
- # 16486
- Diff
- tonypartridge:menu_item_session_data_fix
User tests: Successful: Unsuccessful:
Fixes merging off session data when using two tabs with two separate menu items.
Pull Request for Issue #12222 .
Summary of Changes
Setting conditions for if the item id is null and also if the itemid is equal to that of reloaded item.
This pull request fixes all but 1 scenario which IMHO cannot be solved. You cannot create two new menu items at the same time and reload each expecting it to loading the session data. Unless you were to start tagging unique session stores per browser instance. But it is very unlikely you would be creating two new menu items simultaneously and refreshing one of them before save.
Testing Instructions
Without patch,open up two menu items, on menu item 1 change the Menu Item Type say from article to article list, DO NOT SAVE. Refresh menu item 2 and it will load menu item 1's data.
Expected result
To refresh the page instance it's own data.
Actual result
it loads the previous menu items data from session
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16486.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-12 20:20:20 |
| Closed_By | ⇒ | rdeutz |
Thanks!
I have tested this item✅ successfully on 6c1ac32
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16486.