[#16475] - onUserLoginFailure needs to catch failure to write to log file during failed login
- Fixed in Code Base
- 6 Jun 2017
- Medium
- Build: staging
- # 16475
- Diff
- JEvents:bugsquad
User tests: Successful: Unsuccessful:
Pull Request for Issue #11869
Summary of Changes
Added Try/Catch around the call to JLog::add so that failed attempt to login doesn't throw unhelpful error screen but instead returns visitor to login page as they would if the log file was writeable.
Testing Instructions
Install patch
Login in the backend with incorrect password or missing password
Expected result
return to login page with message about failure to login
Actual result
Now it does this instead of the error page with message about failure to write to log file
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
Now Joomla! redirects to the backend login page and shows the errors in the messages area above the login form.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16475.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16475.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-06 17:28:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
This just needs the code style issues to be addressed (we use tabs instead of spaces), otherwise looks good to me. Thanks!