? ? Success

User tests: Successful: Unsuccessful:

avatar richard67
richard67
3 Jun 2017

Redo of Pull Request #11527 .

Summary of Changes

This PR changes the data type of column checked_out_time in table #__menu from timestamp to datetime so it is equal to the data type of all other checked_out_time columns.

It is a redo of PR #11527 , which was missing the schema update but elsewhere was OK.

So almost all credits should go to the author of PR #11527 , @wmchris .

For some reasons PR #11527 shows something like "unknown branch", and there is no reaction of the author to my post there, so I thought I should make a redo.

There is nothing to be done for MS SQL or Postgresql since for these the data types are already consistent for the checked_out_time column.

Testing Instructions

By code review (should be sufficient):
Check in installation/sql/myssql/joomla.sql of current staging that all columns checked_out_time are of type "datetime" except the one of table #__menu which is of type "timestamp". But the default value and the not null condition are same as for other checked_out_time columns.
Check that this PR fixes this and keeps the comment for the column, and it adds a correct schema update sql script for mysql only which results in the same change as in joomla.sql.

Real test (for paranoids):
Copy the schema update "3.7.3-2017-06-03.sql" from this PR to the correct location of a Joomla 3.7.2 or 3.7.3-dev (current staging) or apply this PR with the patchtester component.
Then go to "Extensions -> Manage -> Database" in the backend and - using the "Fix" button - fix the 2 database problems being shown, telling there is no column checked_out_time of type "datetime" in the menu table and that the schema is not up to date.
It should work without any SQL error, and after that the data type has changed (check in PHPmyAdmin).
To revert this patch, in addition to either removing the "3.7.3-2017-06-03.sql" or reverting the patch with patchtester you have to change back the data type of the column in PHPmyAdmin.

Expected result

Data type of all columns checked_out_time of Joomla core database tables is the same (datetime).

Actual result

Data type of all columns checked_out_time of Joomla core database tables is the same (datetime), except of the #__menu table, where it is timestamp but with a default value suitable for datetime.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 3 Jun 2017
avatar richard67 richard67 - change - 3 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2017
Category SQL Administration com_admin Installation
avatar brianteeman
brianteeman - comment - 3 Jun 2017

(unknown branch means the original author has deleted their own branch)

avatar richard67 richard67 - change - 3 Jun 2017
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2017
avatar richard67
richard67 - comment - 3 Jun 2017

@brianteeman I know, but Github still can show the file and the changes so I was not sure how much that is a problem.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16469.

avatar richard67 richard67 - change - 3 Jun 2017
Title
Synch data type of column checked_out_time in menu table with same column in other tables
Mysql: Synch data type of column checked_out_time in menu table with same column in other tables
avatar richard67 richard67 - change - 3 Jun 2017
Title
Synch data type of column checked_out_time in menu table with same column in other tables
Mysql: Synch data type of column checked_out_time in menu table with same column in other tables
avatar richard67 richard67 - edited - 3 Jun 2017
avatar richard67
richard67 - comment - 3 Jun 2017

@franz-wohlkoenig This PR is a redo of PR #11527 + the missing schema update. Can you close PR #11527 ? It seems the author of that PR has deleted his branch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16469.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Jun 2017

@richard67 closed #11527 in favor of this PR.

avatar richard67 richard67 - change - 3 Jun 2017
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2017
avatar richard67 richard67 - change - 3 Jun 2017
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2017
avatar richard67 richard67 - change - 3 Jun 2017
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2017
avatar richard67 richard67 - change - 5 Jun 2017
Labels Added: ?
avatar richard67 richard67 - change - 5 Jun 2017
The description was changed
Easy No Yes
avatar richard67 richard67 - edited - 5 Jun 2017
avatar Quy
Quy - comment - 5 Jun 2017

I have tested this item successfully on df4bb49


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16469.

avatar Quy Quy - test_item - 5 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

@richard67 applied Patch but no database Problems are shown in "Extensions: Database".
Wrong Number: 16469 instead 16489.

System information

3.7.3-dev (latest nightly build)
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 53 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

I have tested this item successfully on df4bb49


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16469.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Jun 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jun 2017

RTC after two successful tests.

avatar alikon alikon - reference | aa59385 - 8 Jun 17
avatar alikon alikon - reference | e490fd9 - 8 Jun 17
avatar alikon alikon - reference | 0f9d5fd - 8 Jun 17
avatar rdeutz rdeutz - change - 13 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-13 14:55:31
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 Jun 2017
avatar rdeutz rdeutz - merge - 13 Jun 2017

Add a Comment

Login with GitHub to post a comment