User tests: Successful: Unsuccessful:
Redo of Pull Request #11527 .
This PR changes the data type of column checked_out_time
in table #__menu
from timestamp to datetime so it is equal to the data type of all other checked_out_time
columns.
It is a redo of PR #11527 , which was missing the schema update but elsewhere was OK.
So almost all credits should go to the author of PR #11527 , @wmchris .
For some reasons PR #11527 shows something like "unknown branch", and there is no reaction of the author to my post there, so I thought I should make a redo.
There is nothing to be done for MS SQL or Postgresql since for these the data types are already consistent for the checked_out_time
column.
By code review (should be sufficient):
Check in installation/sql/myssql/joomla.sql of current staging that all columns checked_out_time
are of type "datetime" except the one of table #__menu
which is of type "timestamp". But the default value and the not null condition are same as for other checked_out_time
columns.
Check that this PR fixes this and keeps the comment for the column, and it adds a correct schema update sql script for mysql only which results in the same change as in joomla.sql.
Real test (for paranoids):
Copy the schema update "3.7.3-2017-06-03.sql" from this PR to the correct location of a Joomla 3.7.2 or 3.7.3-dev (current staging) or apply this PR with the patchtester component.
Then go to "Extensions -> Manage -> Database" in the backend and - using the "Fix" button - fix the 2 database problems being shown, telling there is no column checked_out_time
of type "datetime" in the menu table and that the schema is not up to date.
It should work without any SQL error, and after that the data type has changed (check in PHPmyAdmin).
To revert this patch, in addition to either removing the "3.7.3-2017-06-03.sql" or reverting the patch with patchtester you have to change back the data type of the column in PHPmyAdmin.
Data type of all columns checked_out_time
of Joomla core database tables is the same (datetime).
Data type of all columns checked_out_time
of Joomla core database tables is the same (datetime), except of the #__menu
table, where it is timestamp but with a default value suitable for datetime.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Installation |
@brianteeman I know, but Github still can show the file and the changes so I was not sure how much that is a problem.
Title |
|
Title |
|
@franz-wohlkoenig This PR is a redo of PR #11527 + the missing schema update. Can you close PR #11527 ? It seems the author of that PR has deleted his branch.
@richard67 closed #11527 in favor of this PR.
Labels |
Added:
?
|
Easy | No | ⇒ | Yes |
I have tested this item
@richard67 applied Patch but no database Problems are shown in "Extensions: Database".
Wrong Number: 16469 instead 16489.
3.7.3-dev (latest nightly build)
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 53 (64-bit)
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 14:55:31 |
Closed_By | ⇒ | rdeutz |
(unknown branch means the original author has deleted their own branch)