[#16456] - Add css class option to image element of menu items
- Fixed in Code Base
- 29 Jun 2017
- Medium
- Build: staging
- # 16456
- Diff
- mattiaverga:menu_image_class
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16447 .
Summary of Changes
Currently we can set a custom class only for anchor element of a menu item.
This change add the option to set a custom class also for the image element associated to the menu item (if any). This way css sprites can be easily used to build menus with icons instead of using many single images, thus reducing overhead.
Testing Instructions
Simply add a new menu element and notice the presence of "Image CSS style" option under the "Link options" tab.
Expected result
Adding a class name under "Image CSS style" will apply a custom class to the img element of menu link item.
Actual result
It's not possible to add a custom class to the img element.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings Modules Front End |
| Labels |
Added:
?
?
|
||
The language strings are not named the same in the xml as in the ini
COM_MENUS_ITEM_FIELD_MENU_IMAGE_CSS_LABEL
COM_MENUS_ITEM_FIELD_IMAGE_CSS_LABEL
Yeah, LABEL and DESC were also inverted. Fixed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.
Should I correct something more?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.
@mattiaverga in Case no more Changes needed this PR needs next a second successfully Test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Milestone |
Added: |
||
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-29 14:09:31 |
| Closed_By | ⇒ | mbabker |
I have tested this item? unsuccessfully on d484d88
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.