? ? ? ? Success

User tests: Successful: Unsuccessful:

avatar mattiaverga
mattiaverga
3 Jun 2017

Pull Request for Issue #16447 .

Summary of Changes

Currently we can set a custom class only for anchor element of a menu item.
This change add the option to set a custom class also for the image element associated to the menu item (if any). This way css sprites can be easily used to build menus with icons instead of using many single images, thus reducing overhead.

Testing Instructions

Simply add a new menu element and notice the presence of "Image CSS style" option under the "Link options" tab.

Expected result

Adding a class name under "Image CSS style" will apply a custom class to the img element of menu link item.

Actual result

It's not possible to add a custom class to the img element.

avatar mattiaverga mattiaverga - open - 3 Jun 2017
avatar mattiaverga mattiaverga - change - 3 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2017
Category Administration com_menus Language & Strings Modules Front End
avatar mattiaverga mattiaverga - change - 3 Jun 2017
Labels Added: ? ?
avatar mattiaverga mattiaverga - change - 3 Jun 2017
The description was changed
avatar mattiaverga mattiaverga - edited - 3 Jun 2017
avatar brianteeman
brianteeman - comment - 3 Jun 2017

I have tested this item 🔴 unsuccessfully on d484d88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

avatar brianteeman brianteeman - test_item - 3 Jun 2017 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 3 Jun 2017

The language strings are not named the same in the xml as in the ini

COM_MENUS_ITEM_FIELD_MENU_IMAGE_CSS_LABEL

COM_MENUS_ITEM_FIELD_IMAGE_CSS_LABEL

avatar mattiaverga
mattiaverga - comment - 3 Jun 2017

Yeah, LABEL and DESC were also inverted. Fixed.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Jun 2017

I have tested this item ✅ successfully on 28a1d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 4 Jun 2017 - Tested successfully
f41b04b 8 Jun 2017 avatar Quy cs
avatar mattiaverga
mattiaverga - comment - 22 Jun 2017

Should I correct something more?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 22 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

I have tested this item ✅ successfully on aac7e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

@mattiaverga in Case no more Changes needed this PR needs next a second successfully Test.

avatar Quy Quy - test_item - 24 Jun 2017 - Tested successfully
avatar Quy
Quy - comment - 24 Jun 2017

I have tested this item ✅ successfully on aac7e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jun 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 25 Jun 2017
Milestone Added:
avatar mbabker mbabker - change - 29 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-29 14:09:31
Closed_By mbabker
avatar mbabker mbabker - close - 29 Jun 2017
avatar mbabker mbabker - merge - 29 Jun 2017

Add a Comment

Login with GitHub to post a comment