Feeling Lucky
?
?
[#16425] - Fixed the typehint for quote functions in `JDatabaseDriver`
- Fixed in Code Base
- 25 Jul 2017
- Medium
- Build: staging
- # 16425
- Diff
- Gavakshi:patch-1
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
Changed the typehint of quote function from string to string and array to reflect actual function return type
Testing Instructions
Code review
Documentation Changes Required
Update typehint
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
izharaazmi
- comment
- 15 Jul 2017
I have tested this item
code review.
We have lot of such issues all over the cms that needs to be addressed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16425.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 19 Jul 2017
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-25 23:44:12 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 88ce41a
Code Review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16425.