?
avatar epidote
epidote
1 Jun 2017

Steps to reproduce the issue

Upgrade from 3.7.1 to 3.7.2

Expected result

"current" menu option available to default Joomla menu module

Actual result

"current" menu option missing from default Joomla menu module

System information (as much as possible)

3.7.2

Additional comments

discussed here
https://forum.joomla.org/viewtopic.php?f=708&t=951300&p=3477349#p3477349

screen shot 2017-06-01 at 09 50 31

avatar epidote epidote - open - 1 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Jun 2017
avatar infograf768
infograf768 - comment - 1 Jun 2017

Hmm, this has already been the case in 3.7.0
See PR #11694

It indeed has not been proposing "Current" since we implemented the modal_menu

avatar infograf768
infograf768 - comment - 1 Jun 2017

ok, iguess that, for that, we have to revert that one to use the other menu type

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jun 2017
Status New Discussion
avatar infograf768
infograf768 - comment - 2 Jun 2017

Afterthought:
We just have to change the Tip as, basically, not selecting a menu item for that field (therefore displaying Select a Menu Item ) is equal to the former Current.
Will make PR.

avatar infograf768
infograf768 - comment - 2 Jun 2017

Well, again some new thought:

the issue is larger than that in fact.
We have multiple modal_menu types in xmls where we have also the option Default (all the redirects for example)
These Options are not taken into account in the UI. We have everywhere 'Select a Menu Item' instead.
Therefore, if we just take care of the tips, my guess is we should also take off from the xmls these now useless options, i.e. delete <option value="">JDEFAULT</option>

Obviously, the nicest solution would be to reinstate the use of the possible Option and leave the tips and xmls alone.

I tried to do that by reinstating some of my original code in the modal_menu type, but I have some issues in the sense that the option displays nicely when opening an item to edit, but we lose it if we select a menu item, then clear.

@Bakual @dgt41
What do you think/can do?

avatar infograf768
infograf768 - comment - 2 Jun 2017

Note: the issue is not new to 3.7.2 vs 3.7.1. It was present since 3.7. imho

avatar infograf768
infograf768 - comment - 3 Jun 2017

Please test this patch where we do respect the Option placeholder.
#16459

avatar infograf768 infograf768 - change - 3 Jun 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-06-03 07:33:28
Closed_By infograf768
avatar infograf768 infograf768 - close - 3 Jun 2017

Add a Comment

Login with GitHub to post a comment