Feeling Lucky
?
[#16409] - [com_content] /components/com_content/views/form/view.html.php contains unneeded check
- Closed
- 1 Jun 2017
- Medium
- Build: staging
- # 16409
Steps to reproduce the issue
Code review of the file /components/com_content/views/form/view.html.php, lines 49 — 77.
Expected result
if (!empty($this->item->id))
Actual result
if (!empty($this->item) && isset($this->item->id))
System information (as much as possible)
Joomla 3.7.2
Additional comments
The check !empty($this->item) is unneeded or must be above. E.g., this check is absent at the line 53.
I think, it is possible to join the statements of if conditions at the lines 72 and 77.
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | Feature Request SQL |
nvyush
- comment
- 1 Jun 2017
Bakual
I have some trouble with this now.
Bakual
- comment
- 1 Jun 2017
I can try to help if you tell me what the trouble is
nvyush
- comment
- 1 Jun 2017
I use online github. My fork is inconsistent. I can't create second fork and I don't want to drop my fork.
Bakual
- comment
- 1 Jun 2017
If you edit the file on this repo instead of your fork, then GitHub will automatically create a new branch in your fork based on this repo here.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-01 08:27:53 |
| Closed_By | ⇒ | nvyush |
Since you already propose some code, can you please create a Pull Request so it can be tested?
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests