[#16406] - Allow to disable js/css assets auto-reload in system debug plugin
- Fixed in Code Base
- 13 Jun 2017
- Medium
- Build: staging
- # 16406
- Diff
- andrepereiradasilva:patch-19
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16381.
Summary of Changes
Adds an option to the debug system plugin to allow to disable the js/css assets auto-reload on every page load in system debug plugin.
Testing Instructions
- Apply patch
- Enable debug system plugin and debug in global config
- Check there is a media version hash in assets (js/css) in the page source code
- Now, in the debug system plugin disable the new "Refresh Assets" option
- Save, reload the page and check there is no media version hahs in assets (js/css) in the page source code
Expected result
Allow to disable js/css assets auto-reload in debug system plugin.
Actual result
Not allowed to disable js/css assets auto-reload in debug system plugin.
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
The language strings make sense to me
@Quy @brianteeman english is not my native language, please feel free to change the language strings to what you think is more correct.
But it may cause problems due to misunderstanding / misuse of it by end users !
If some end-users, use the new option to disable the adding of the Version URL variable to the JS / CSS files
-- then when at some point they re-enable debug after a joomla upgrade, then their browsers maybe use old cached data from a previous Joomla version
(at least since it is inside a plugin they will probably never find it)
@ggppdk not sure i understand, you are describing a hypothetical scenario in which a end-user deliberate enabled the debug plugin and deliberate disabled this new option in a live production site? ... if so is your opinion that this something joomla core need to that in consideration?
@andrepereiradasilva
This PR is good, what i described will be rare
I have tested this item
Working well. @GeraintEdwards Can you test when you get a minute please.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16406.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16406.
Can someone run drone please
just updated branch to rerun tests
Great, can someone put an RTC on this? since it has passed two tests? @franz-wohlkoenig ?
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
My Hero!
On 6 Jun 2017, 11:19 +0100, Franz Wohlkönig notifications@github.com, wrote:
RTC after two successful tests.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
Enable debug system plugin and debug in global config
It is not necessary to enable debug in global config for this to work. Is it ok?
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16406.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16406.
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 14:48:05 |
| Closed_By | ⇒ | rdeutz |
I would say that this works,
-- and it would quite useful for developers
-- and for running the site faster when debug is ON
But it may cause problems due to misunderstanding / misuse of it by end users !
If some end-users, use the new option to disable the adding of the Version URL variable to the JS / CSS files
-- then when at some point they re-enable debug after a joomla upgrade, then their browsers maybe use old cached data from a previous Joomla version
(at least since it is inside a plugin they will probably never find it)
The description of new parameter says "so they never use the browser cache",
and "no browser cache" will sound bad to end users and they will disable it
also even for people that understand it , they may disable it , and then just leave it off and forget about it
maybe a better description (language string) is needed here