? Pending

User tests: Successful: Unsuccessful:

avatar yvesh
yvesh
31 May 2017

Summary of Changes

Generates an autoload_psr4.php file with namespace and folder for the namespaced extensions. (First version, there needs to be done some follow ups)

Testing Instructions

Apply patch, and reload the page. Make sure there are no errors or notices and than check if there in the libraries folder there is a 'autoload_psr4.php' file created. (but only on first load)

This should be also updated on extension update, install, publish / unpublish etc.

As when the plugin is not enabled this can break the entire site, we should reevaluate protecting plugins / extensions OR move it to the installer etc.

Expected result

Actual result

Documentation Changes Required

Probably

avatar yvesh yvesh - open - 31 May 2017
avatar yvesh yvesh - change - 31 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2017
Category Libraries Front End Plugins
avatar wilsonge wilsonge - change - 31 May 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 31 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-31 17:45:22
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 May 2017
avatar wilsonge wilsonge - merge - 31 May 2017
avatar Bakual
Bakual - comment - 1 Jun 2017

@wilsonge Honestly, this should never have been merged without any discussion. Especially since @yvesh himself said

As when the plugin is not enabled this can break the entire site, we should reevaluate protecting plugins / extensions OR move it to the installer etc.

That's just not going to work using a plugin. Something as elementary as this has to be part of the extension installer itself.
Also it only takes care of components. But the methods retrieve all extensions....

avatar Bakual
Bakual - comment - 1 Jun 2017

Also the autoload_psr4.php file needs to be added to .gitignore.
It also likely needs the JEXEC or die statement and some comment about the purpose of the file would be nice as well.

avatar Bakual
Bakual - comment - 1 Jun 2017

Plugin isn't even installed, the necessary SQL files are all missing.

avatar laoneo
laoneo - comment - 3 Jun 2017

Agree, especially as the whole goal is not clear from that pr where the journey should go.

avatar Bakual
Bakual - comment - 3 Jun 2017

Created a PR to revert this one: #16464

Add a Comment

Login with GitHub to post a comment