? ? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
30 May 2017

Pull Request for Issue #15447 .

Set menu item type on save, so when using save and new for instance the menu item type is passed through again.

avatar tonypartridge tonypartridge - open - 30 May 2017
avatar tonypartridge tonypartridge - change - 30 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2017
Category Administration com_menus
avatar tonypartridge tonypartridge - change - 30 May 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 30 May 2017

I have tested this item successfully on ec3b9e5

awesome stuff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16374.

avatar brianteeman brianteeman - test_item - 30 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 May 2017

@tonypartridge who needs a codesniffer when you have a @Quy

avatar tonypartridge
tonypartridge - comment - 30 May 2017

Exactly! He's ace, I wouldn't mind but I've been trying to optimise my IDE so it tells me before sending a PR. Clearly there is something wrong with the https://github.com/joomla/coding-standards repo. or my system since I am using that repo to set the rules of codesniffer. More investigation to be done!

avatar tonypartridge
tonypartridge - comment - 30 May 2017

Fixed codesniffer now!

avatar Quy
Quy - comment - 30 May 2017

I have tested this item successfully on ac3c62a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16374.

avatar Quy Quy - test_item - 30 May 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 May 2017

I have tested this item successfully on ac3c62a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16374.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 31 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 May 2017
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 31 May 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 8 Jun 2017
Labels Added: ?
avatar tonypartridge
tonypartridge - comment - 8 Jun 2017

Travis passed! Woohoo

avatar rdeutz rdeutz - change - 8 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-08 20:50:31
Closed_By rdeutz
avatar rdeutz rdeutz - close - 8 Jun 2017
avatar rdeutz rdeutz - merge - 8 Jun 2017

Add a Comment

Login with GitHub to post a comment