[#1637] - explicit type check
- Closed
- 26 Sep 2014
- Medium
- Build: master
- # 1637
- Diff
- pdxfixit:mediahelper-eval
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
If $format = '', then the first check is included in the second.
Also, if a file extension "foo.0" were to be uploaded, ("0" == false) evaluates as true.
Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.
As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:
1) Open an item on the Joomlacode tracker in the appropriate area.
CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549
2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.
| Status | New | ⇒ | Pending |
| Build | ⇒ | . |
As this function has now been deprecated and removed I am closing this
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-26 14:12:28 |
The 0 is actually returned as '0' not 0 so it evaluates as true. Currently it would be very weird to ever get a false at all (that's part of the problem, you get an empty string not a false) but doing a strict test is reasonable.