[#16355] - Fix a problem with older Joomla versions language packs registration and update sites rebuild
- Fixed in Code Base
- 21 Jul 2018
- Medium
- Build: staging
- # 16355
- Diff
- klas:patch-1
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Language packs installed under older Joomla versions are registered in the database under their package name, not under their name and since rebuild function fails on them.
e.g. package with
<name>Afrikaans (South Africa)</name>
<packagename>af-ZA</packagename>
has name column in #_extensions table set as af-ZA and since existing update sites rebuild fails.
Testing Instructions
Set language package name in #_extensions to its packagename. Hit rebuild on update servers.
Expected result
Update server from this package is on the list.
Actual result
Update server from this package is not on the list of update servers.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
@brianteeman it is not a problem with language packs themselves, it seems like change of installer functionality from older Joomla versions (my packs have version numbers around 3.2). In those versions installer registered them in #__extensions name column under their packagename tag. This has changed somewhere along the path as new packs have name set to their name tag (can't tell whether this is a correct behaviour or not).
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
Thanks for clarifying
Basically, one has to install an older version of J! Install lang packs and test from there.
IMPORTANT:
One has to make sure that the en-GB package is present in the _extensions table
I had to run
INSERT INTO `jos_extensions` (`extension_id`, `package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `system_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES
(802, 0, 'English (en-GB) Language Pack', 'package', 'pkg_en-GB', '', 0, 1, 1, 1, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0);
to solve the issue.
Once it is solved, reinstalling the language pack corrects the db
I had this problem, did what @infograf768 said through SQL and then went through joomla panel into Extensions > Update Sites > Rebuild. Worked great!
@infograf768 thanks!
after rebuild everything well!
@Quy is the Code from @infograf768 Comment Part of the PR?
@franz-wohlkoenig No. I think it is only to test the PR.
This is RTC and fine to merge. The comment about the database record deals with the fact that package didn't exist on older Joomla versions.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-21 02:16:29 |
| Closed_By | ⇒ | mbabker |
@klas to help with testing can you give an example of a language pack that will need this PR