[#16334] - Remove legacy redirect functionality
- Fixed in Code Base
- 29 May 2017
- Medium
- Build: 4.0-dev
- # 16334
- Diff
- wilsonge:remove-redirect-legacy-code
User tests: Successful: Unsuccessful:
Summary of Changes
Removes legacy handling of redirect code and let's it all proxy up the the framework redirect method. This has two b/c implications:
-
We remove the behaviour deprecated since 3.2 where we redirect with a message and message type as params 3 and 4
-
Passing in a true/false value as the 2nd/3rd params instead of a redirect code will give an
InvalidArgumentExceptioninstead of defaulting to a 303, deprecated since 3.4
On top of this we are technically reverting joomla-projects/joomla-cms@f557845 (the js fix part) as it never made it into the framework and @mbabker can't tell me why it's there.
Also removes JApplicationWeb::$singleValueResponseHeaders which has been totally unused since @mbabker 's refactor a few months ago
Testing Instructions
No change in redirects other than documented functionality
Documentation Changes Required
Document removal of deprecated function options
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-29 15:23:28 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Just for additional context for those reading this,
JApplicationWeb::$singleValueResponseHeadersis now unnecessary because the Framework Application will be internally using PSR-7 Response objects as of its 2.0 release. This support doesn't fundamentally do anything for the CMS right now, but similar to the HTTP API, it changes how the headers data is stored so it is always a multi-dimensional array with each top level key being the header names and the value being an array holding all of the values for that header. So this actually gives developers a little more fine grained control over the header stack in general.