? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
29 May 2017

Summary of Changes

Similar to #16259 this creates a service factory for use with creating objects in the Toolbar API. This should make things a little more flexible as it relates to creating new objects and creating custom objects if needed in extensions.

Testing Instructions

Fundamentally, this is the same as #16259 for testing. The CMS by default should continue to function without error, for those looking for advanced integrations they can create and inject new logic.

Documentation Changes Required

  • As of 5.0, when a Toolbar object is created a factory must be passed into the constructor; for ease of migration with 4.0 this won't be a required argument
  • Typehint and document the correct Toolbar object in the ToolbarButton constructor, this breaks B/C if anyone were trying something like new StandardButton(new stdClass); but since the class internals would break without a Toolbar instance and the number of places where one should be direct instantiating a ToolbarButton should be minimal (if at all) so it should be a low risk change
avatar mbabker mbabker - open - 29 May 2017
avatar mbabker mbabker - change - 29 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2017
Category Installation Libraries
avatar wilsonge wilsonge - change - 31 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-31 10:35:52
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 31 May 2017
avatar wilsonge wilsonge - merge - 31 May 2017
avatar joomdonation
joomdonation - comment - 31 May 2017

Look like this causes backend broken. See the errors in screenshot below:
toolbar_error

avatar mbabker
mbabker - comment - 31 May 2017

Fixed - 3ff944b

Add a Comment

Login with GitHub to post a comment