? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 May 2017

The licence file we include is named LICENSE.txt but 748 files referred to just LICENSE

NB I excluded vendor supplied files obviously AND fof and libraries/joomla
as my understanding that any changes for these should be made upstream. If that is wrong I can always update this PR

avatar brianteeman brianteeman - open - 29 May 2017
avatar brianteeman brianteeman - change - 29 May 2017
Status New Pending
avatar brianteeman brianteeman - change - 29 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2017
Category Administration com_content com_contenthistory com_finder
avatar zero-24
zero-24 - comment - 29 May 2017

The licence file we include is named LICENSE.txt but 748 files referred to just LICENSE

https://github.com/joomla/joomla-cms/blob/staging/installation/LICENSES ?

Isn't it the other way?

avatar brianteeman
brianteeman - comment - 29 May 2017

@zero-24 installation is a different issue see #14296

The license file referred to is https://github.com/joomla/joomla-cms/blob/staging/LICENSE.txt

avatar zero-24
zero-24 - comment - 29 May 2017

Ah. Sorry looks like i overlooked this file.

avatar Quy
Quy - comment - 29 May 2017

I have tested this item successfully on 33c0cf9

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16317.

avatar Quy Quy - test_item - 29 May 2017 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 29 May 2017

I have tested this item successfully on 33c0cf9

On Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16317.

avatar tonypartridge tonypartridge - test_item - 29 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 May 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 29 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-29 15:34:50
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 May 2017
avatar wilsonge wilsonge - merge - 29 May 2017
avatar wilsonge
wilsonge - comment - 29 May 2017

Thanks Brian!

avatar brianteeman
brianteeman - comment - 29 May 2017

thanks

Add a Comment

Login with GitHub to post a comment