? ? Failure

User tests: Successful: Unsuccessful:

avatar yaume
yaume
29 May 2017

Un unordered list seems to be semantically wrong. An ordered list could be better

Issue #16312

Documentation Changes Required

Google guides
BreadcrumbList

avatar yaume yaume - open - 29 May 2017
avatar yaume yaume - change - 29 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2017
Category Modules Front End
avatar brianteeman
brianteeman - comment - 29 May 2017

I suspect that this will have to wait until j4 as it potentially will break the layout on an existing site

avatar yaume
yaume - comment - 29 May 2017

It'll wait quite easely as it's not very important and it can be overrided

avatar brianteeman brianteeman - change - 29 May 2017
Title
Changing unordered list to ordered list
breadcrumbs Changing unordered list to ordered list
avatar brianteeman brianteeman - edited - 29 May 2017
avatar brianteeman brianteeman - change - 29 May 2017
Title
Changing unordered list to ordered list
breadcrumbs Changing unordered list to ordered list
avatar brianteeman
brianteeman - comment - 29 May 2017

updated title

avatar C-Lodder
C-Lodder - comment - 19 Jul 2017

Seem fine for J4.

@yaume - would you mind submitting a PR against the 4.0-dev branch instead?

avatar zero-24
zero-24 - comment - 19 Jul 2017

@C-Lodder i have just changed the base branch. So @yaume don't need to do anything ;) Just someone review / test & merge against 4.0

avatar zero-24 zero-24 - change - 19 Jul 2017
Milestone Added:
avatar C-Lodder C-Lodder - test_item - 19 Jul 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 19 Jul 2017

I have tested this item successfully on 2c361e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313.

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jul 2017
Build staging 4.0.0.-dev
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2017
Milestone Removed:
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Jul 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2017

I have tested this item 🔴 unsuccessfully on 2c361e7

please see Screenshot below for Reason of unsuccessfully Test:

bildschirmfoto 2017-07-20 um 16 08 28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313.
avatar C-Lodder
C-Lodder - comment - 20 Jul 2017

Hmm, worked for me in FF. What browser are you using @franz-wohlkoenig ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2017

System information

4.0.0-dev
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar brianteeman brianteeman - test_item - 28 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jul 2017

I have tested this item successfully on 2c361e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313.

avatar brianteeman brianteeman - change - 28 Jul 2017
Title
breadcrumbs Changing unordered list to ordered list
[4.0] breadcrumbs Changing unordered list to ordered list
avatar brianteeman brianteeman - edited - 28 Jul 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Jul 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2017

RTC after two successful tests.

avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

Are you still having issues with this one franz?

avatar zero-24 zero-24 - change - 17 Aug 2017
Labels Added: ? ?
Removed: ? ?
avatar zero-24
zero-24 - comment - 17 Aug 2017

any feedback on this @franz-wohlkoenig ?

avatar brianteeman
brianteeman - comment - 17 Aug 2017

Once this is merged we can look at making it accessible

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Aug 2017

Sorry @zero-24 , missed Question. Will have a Look when #17594 is solved.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2017

@C-Lodder Answer on your Comment: Issue is solved.

avatar zero-24
zero-24 - comment - 19 Aug 2017

merging than. Thanks for the feedback. Thanks @yaume for your contribution!

avatar zero-24 zero-24 - change - 19 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-19 12:16:54
Closed_By zero-24
avatar zero-24 zero-24 - close - 19 Aug 2017
avatar zero-24 zero-24 - merge - 19 Aug 2017

Add a Comment

Login with GitHub to post a comment