? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
28 May 2017

While testing the stubGenerator PR from Michael I found that we register alias for classes that no longer exist in 4.0.

Summary of Changes

This removes the class mapping for the three observer classes that got removed.

Testing Instructions

Not much to test here. Review should be enough since those classes just don't exist anymore.

Documentation Changes Required

The removing of the observer classes has to be documented as B/C break, but I hope that's already done by the PR which actually removed the oberserver ?

avatar Bakual Bakual - open - 28 May 2017
avatar Bakual Bakual - change - 28 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2017
Category Libraries
avatar wilsonge wilsonge - change - 29 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-29 08:15:33
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 May 2017
avatar wilsonge wilsonge - merge - 29 May 2017
avatar wilsonge
wilsonge - comment - 29 May 2017

Thanks! Actually that isn't actually a PR. That was some code by Nic in the early days of pythag which I ported across to the 4 branch here. It's a good point though, because all that needs to be written up

avatar Bakual
Bakual - comment - 29 May 2017

Added the documentation required label for now.
Or do you already have a way to keep track of that stuff?

avatar wilsonge
wilsonge - comment - 29 May 2017

Documentation required is the way of tracking

Add a Comment

Login with GitHub to post a comment