[#16293] - Using JLayout for combo field
- Fixed in Code Base
- 31 Jul 2017
- Medium
- Build: staging
- # 16293
- Diff
- degobbis:combo
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Please make sure that combo field still work
Usage
See Combo form field type on Joomla!
Expected result
the combo filed can be overwritten using a layout
Actual result
No usage of a layout
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
I can confirm that it sill works as bevore. But it looks like that combo field is broken before and after the patch. Maybe @ciar4n can take a look here if it is realted to the isis restyle.
I have just used the sample code prodvided here: https://docs.joomla.org/Combo_form_field_type
<field name="myeditbox" type="combo" label="MyEditBox" description="myeditbox_Desc" size="7">
<option value="1">Option 1</option>
<option value="2">Option 2</option>
</field>
And added it here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/config.xml#L18
I can only really help with CSS. This appears to be more of a JS issue. The dropdown here is been positioned by JS added inline. Only on some views it appears to be positioning relevant to the toggle button rather than the input field. Testing this in a module XML and it appears to work fine
I have tested this item
It works like before and the issue i mention above is a different one. Thanks @degobbis
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16293.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16293.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-31 11:47:18 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@degobbis i have just fixed some things spaces to tabs and the usage of deploy version ;)