[#16290] - [4.0]Update and fix InstallerHelper accordingly to processHeaders
- Fixed in Code Base
- 27 May 2017
- Medium
- Build: 4.0-dev
- # 16290
- Diff
- joeforjoomla:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
The InstallerHelper class must be updated to evaluate correctly header values based on the new processHeaders function contained in the class \Joomla\Http\AbstractTransport
Expected result
Header value evaluated correctly in:
$response->headers['Content-Disposition']
Actual result
The header value is assigned to an array thus requiring:
$response->headers['Content-Disposition'][0]
to access it.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-27 20:00:14 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Nice catch. Thankyou!
In general this will need to be updated for 4.0 since we switched from using our custom response object to following the PSR-7 ResponseInterface (which defines the headers array in a way that supports headers with multiple values). Minor annoyance, but better API.
Good job guys!
(Updated title to show 4..0)