[#16284] - Fix Stylesheet Mime type keeping b/c
- Fixed in Code Base
- 27 May 2017
- Medium
- Build: staging
- # 16284
- Diff
- PhilETaylor:RSSMimeType
User tests: Successful: Unsuccessful:
Pull Request for Issue #16266.
Summary of Changes
Ensure b/c and ensure mime type is set on XML Stylesheets in RSS Feeds without PHP undefined index error.
Steps to replicate,
- Edit /libraries/joomla/document/feed.php
- On Line 206 (or anywhere in the render function, this is just to break it) add code:
// 3/4 style with no options or attribs
$this->addStyleSheet('/media/system/css/modal.css');or
// 3 with mime specified
$this->addStyleSheet('/media/system/css/modal.css','text/css');or
// Joomla 4 with type specified
$this->addStyleSheet('/media/system/css/modal.css',array(),array('type'=>'text/css'));-
View any RSS feed created by your Joomla site (mine: E.g.: index.php?option=com_content&view=featured&Itemid=109&format=feed&type=rss)
-
see error message in the RSS of:
Then Apply this PR,
Expected result
No error
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
All this changed! b325dcd#diff-88fc539e0ca61aec41d3fe2cb09ecc02
In fact looking at the comments:
* @deprecated 4.0 The (url, mime, media, attribs) method signature is deprecated, use (url, options, attributes) instead.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16284.
We will change it before J4.
thnx for the fix
Actually I have changed this PR to a different approach to fix the logic in the change for b/c made last year. This works better as it only effects the b/c block and not two different files.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16284.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16284.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-27 17:48:49 |
| Closed_By | ⇒ | rdeutz |
what change in 3.7 introduced this "error"? Surely we should be reviewing what broke things before coding solutions. Perhaps the thing thhat broke this broke something else as well which hasnt been reported yet