[#16279] - Fix notices on Contact form
- Fixed in Code Base
- 27 May 2017
- Medium
- Build: staging
- # 16279
- Diff
- weeblr:patch-3
User tests: Successful: Unsuccessful:
Notice errors are displayed when "Contact information" is disabled, and either Slides or Tabs display format is used.
Summary of Changes
When displaying com_contact "contact" view, using either Tabs or Sliders display format, multiple notices are thrown by PHP, if "Contact information" is disabled. It happens because the Accordion or the Tab set is only created when "Contact information" is displayed, and therefore is missing if "Contact information" is hidden.
This PR tracks the opening of Accordion and Tab set, and make to open then if it has not been done yet.
Testing Instructions
-
Create a com_contact menu item of type Single contact
-
Under Contact display options, select Sliders as the Display format.
-
Under Contact display options, set Contact information to Hide
-
In Joomla configuration, set Error reporting to Maximum
-
Visit the front end using that menu item
-
Perform the same test when selecting Tabs as the Display format
Expected result
The contact form with no error.
Actual result
You will get notices `errors:
Notice: Undefined index: JHtmlBootstrap::startAccordion in /src/main/libraries/cms/html/bootstrap.php on line 687
Notice: Undefined index: JHtmlBootstrap::startAccordion in /src/main/libraries/cms/html/bootstrap.php on line 688
Notice: Undefined index: JHtmlBootstrap::startAccordion in /src/main/libraries/cms/html/bootstrap.php on line 689
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Labels |
Added:
?
|
||
I have tested this item
Tested with success.
Had to clear Joomla cache all the time after having changed the display format, but that's another issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16279.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Please remove RTC. There are many coding style issues to be fixed.
Concerning the coding style issue:
It is indeed necessary to use tabs for indentation and a space after if, but it is not necessary to add a white line before <?php if (
| Status | Ready to Commit | ⇒ | Pending |
Status set on "Pending".
should be OK, now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16279.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16279.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-27 06:50:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 2eb78f3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16279.