[#16268] - Fix double encode ampersand in contact select list
- Fixed in Code Base
- 26 May 2017
- Medium
- Build: staging
- # 16268
- Diff
- matrikular:patch-14
User tests: Successful: Unsuccessful:
Summary of Changes
As @infograf768 mentioned here: #15973 (comment) there seems to be a bug in the com_contact view that leads to double encoded ampersands being inserted for each link / url of the contact select list.
Because of this, the url isn't recognised correctly and the params aren't merged properly.
Testing Instructions
- Apply #16264
- Create at least two contacts in the same category and make sure to fill in an email address.
- Create a menu item for those two contacts.
- Set the "Disable the "Add Mailto: Link" parameter in one of the menu items to "Show", leave the other to "Use Global"
- Set the "Show Contact List" parameter in the com_contact options to "Show"
- Set the "Disable the "Add Mailto: Link" parameter in the com_contact option to "Hide"
Expected result
Given that at least two contacts are accessible via a menu item, only one contact should have a mailto link attached to the address. This should be the case whether you've selected a contact from the contact list (select) or via a menu item.
Another indicator would be, that the breadcrumb navigation always shows the contacts alias as the last element.
Actual result
While in @infograf768 test the mailto links were both always on, in mine (after applying #16264), the mailto links for all contacts were always off. Either way, an indication that the params have been merged incorrectly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
@franz-wohlkoenig thank you for your input. I guess my mind was still on the form while writing the instruction. I've updated the instructions.
@matrikular
Applied both PRs. It is a bit confusing to apply both to solve that issue.
Is it OK if the contact parameters override both the Global param and the menu item param?
If OK, this works fine, although we could go further and add in the featured contacts menu item the contact parameters to the choice between Yes, No, and Global params,
Also, I think we should add a showon in the xmls for the new add_mailto_link
@infograf768 I've corrected the behavior that is responsible for how the parameters get merged in a different PR. The only problem was that I falsely solved the conflicts that occoured right before the PR got merged. Before that, a contact item setting would overrule the menu item. Please have a look at #15747 for more information on that topic. I've tested this in three different systems now and (fingers crossed) after the correction, it should behave exactly like com_content does.
In regards to this PR - #15747 only changes the way the symptoms represent themselves. Since you mentioned the bug that his PR solves in conjunction with the mailto link option, including that PR will keep everyone on the same page.
If you ignore the add mailto option and just focus on the contact select list in a system without the mailto option (< 3.7.3 (staging)), another indicator would be that the breadcrumb navigation would lose its last element (the contact).
@matrikular test by download https://github.com/matrikular/joomla-cms/archive/patch-14.zip and apply this PR? Cause 2PR at same Time wasn't allowed.
Mh, I see,... since you cannot apply both PRs at the same time, you can easily add the changes from #16264 to patch-14 manually or vice versa.
In components/com_contact/views/contact/view.html.php #L152 and #L154 it should read $item->params->get. instead of $params->get
@matrikular In components/com_contact/views/contact/view.html.php of https://github.com/matrikular/joomla-cms/archive/patch-14.zip get:
So i can test this Installation + this PR?
@franz-wohlkoenig if you take this branch, which is patch-14, and install patchtester to apply the changes from #16264, you're good to go.
Thank you for your patience.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16268.
I have tested this item
Let's get this in as well as the other one.
We will therefore be able to deal with some of my suggestions
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16268.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16268.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-26 15:27:18 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
The false in the method call is the trick as far as I know.
Indeed, afaik too
* @param boolean $xhtml Replace & by & for XML compliance.
public static function _($url, $xhtml = true, $ssl = null)
I assigned each Contact to a different User > E-Mail isn't shown in Contact (Contact-Options "Email" is set on "Show"). Adding E-Mail manually in Contact: E-Mail is shown.