[#16257] - Add truncate class and implement in popular articles module
- Fixed in Code Base
- 26 May 2017
- Medium
- Build: staging
- # 16257
- Diff
- mbabker:popular-break
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #12648
Summary of Changes
This adds a .truncate class to Isis to truncate long text. To fix the issue with the popular articles module wrapping text, this truncate class is implemented.
Testing Instructions
Generate an article with a long title, get it to show up in the popular articles backend module, and have the module display in the admin dashboard with a span6 option so the module is somewhat smaller. Pre-patch, you should get an awkward looking break. Post-patch, the title will truncate and using the title attribute when hovering over the text it'll show the full non-truncated text.
Expected result
Should look something like the first item in this image
Documentation Changes Required
If we have the CSS documented anywhere, add that.
Anyone who thinks they can do this better than me is welcome, I can barely write anything that's not PHP
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16257.
Works as intended but i think the same should be done for the recently added articles and probably everywhere that break-word was added to the admin as a class
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16257.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Seems fine to me. The only thing I'd probably suggest is adding the truncate class to a child div instead of the grid element, like so:
<div class="span8">
<div class="truncate">
....
</div>
</div>
It's more for semantic purposes but not a big issue. Can be left as is
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-26 17:56:32 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on e27bec0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16257.