?
avatar okonomiyaki3000
okonomiyaki3000
31 Jul 2013

There's a regexp that SublimeText seems to choke on. It's in JDate, right here:
https://github.com/joomla/joomla-cms/blob/master/libraries/joomla/date/date.php#L281-L285

So there are some lines that look like:

$format = preg_replace('/(^|[^\\\])D/', "\\1" . self::DAY_ABBR, $format);

Inside the [], the first \ (PHP string) escapes the second one and the third is literal. So this give us regexp like /(^|[^\\])D/ in which the first one again (regexp) escapes the second one.

I think I know why SublimeText acts funny here but it doesn't matter much. I wonder if (for the benefit of us ST users) the string could be changed to:

$format = preg_replace('/(^|[^\\\\])D/', "\\1" . self::DAY_ABBR, $format);

I don't think it makes any difference as far as they way the code works. Am I missing something?

avatar okonomiyaki3000 okonomiyaki3000 - open - 31 Jul 2013
avatar brianteeman
brianteeman - comment - 13 Oct 2013

Thanks for reporting this. At this time we are only using github as the place to submit code fixes so I am closing the report here. The actual reporting of issues and testing fixes is still taking place on Joomlacode.

As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta.

If it is still valid please can you open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

avatar zero-24 zero-24 - close - 13 Oct 2013
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Removed: ? ?
Build staging

Add a Comment

Login with GitHub to post a comment