wont the code in com_templates that creates overrides need changing as well?

Nope, overrides are the same.

It would need to know where to look to find the overrides though.

@mbabker is there any plan to refactor the override creator part?

I'v just tested it and overrides do work as before.

@laoneo creating an override?

Yes

It would need to know where to look to find the overrides though.

how does it know where to look if the files have moved

@brianteeman everything happens here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_templates/models/template.php#L737-L786

So yes it should work as is

Why do you guys don't believe me, it works 😩

@dgt41 that code is for creating the files and folders - i am talking about the code that finds the views that can be overriden

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_templates/models/template.php#L569-L597

thanks @mbabker

and reading that code I cant see how it can find a view in the new location - but thats probably my lack of skill at reading code if @laoneo says it does. Anyway this is what I was referring to in my first comment

This change here https://github.com/joomla/joomla-cms/pull/16218/files#diff-c0ed342062e86e3c3f81da894f9d3e8fR137 adds the tmpl path to the file lookup array.

@laoneo I think Brian is talking about the code which is used to create override in Template Manager. See the block of code which Michael mentioned https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_templates/models/template.php#L569-L597

Since the layout is now moved to new location, we need to adjust that block of code to allow template manager to find layout from new location

I was thinking I do miss something. Will have a look on that as well.

Yes that's exactly what I meant

Changed the override editor to support the new scheme as well. Updated the test instructions.

I have tested this item 🔴 unsuccessfully on b9b0e6d

creating overrides is not building the path correctly if the site is installed in a subdirectory as it is including the subdirectory that the site is installed in

this screenshot shows an override created before applying this pr at the bottom and after applying this pr at the top. you will see that my site is installed in a subdirectory called cms4

I just tested it and it again and I'm working in a subfolder as well, it worked as it should. For a test can you install it from here https://github.com/Digital-Peak/joomla-cms/archive/j4/move-views-tmpl.zip, just to be sure the full patch get applied.

Retested as requested with your zip - no change

Perhaps somebody else can test it as I don't know what to do more. Guess we will have another look on the code sprint as well. Thanks so far for testing.

I don't see the problem like Brian mentioned, but there are still issues with creating overrider:

1. For com_users (old layout structure), the override is created at html\view\com_users\views\login . It should be html\com_users\login only

2. For com_content (new layout structure), the override is created at html\view\com_content\tmpl\article, it should be html\com_content\article only

Forgot to mention I am using Windows. And I installed your branch for testing. So something is still not correct yet

@joomdonation I am on windows too

Also, maybe the code in foreach block of getOverridesList method could be changed to:

foreach ($components as $component)
{
	$requireTmplFolder = true;

	if (file_exists($componentPath . '/' . $component . '/tmpl/'))
	{
		$viewPath = \JPath::clean($componentPath . '/' . $component . '/tmpl/');
		$requireTmplFolder = false;
	}
	elseif (file_exists($componentPath . '/' . $component . '/views/'))
	{
		$viewPath = \JPath::clean($componentPath . '/' . $component . '/views/');
	}
	elseif (file_exists($componentPath . '/' . $component . '/view/'))
	{
		$viewPath = \JPath::clean($componentPath . '/' . $component . '/view/');
	}
	else
	{
		$viewPath = '';
	}
	
	if ($viewPath)
	{
		$views = \JFolder::folders($viewPath);

		foreach ($views as $view)
		{
			// Only show the view has layout inside it
			if (!$requireTmplFolder || file_exists($viewPath . $view . '/tmpl'))
			{
				$result['components'][$component][] = $this->getOverridesFolder($view, $viewPath);
			}
		}
	}
}

I think it is less change, easier to understand (maybe just me) and save \JFolder::folders call on unnecessary folders.

the override creation works for me now

Good to hear

Seems good to me. Let's get the rest of the core component converted :)