[#16204] - Correcting vote notice
- Closed
- 23 May 2017
- Medium
- Build: staging
- # 16204
- Diff
- infograf768:notice_rating
User tests: Successful: Unsuccessful:
Pull Request for Issue #16203
PHP Notice: Undefined property: JCategoryNode::$rating_count in ../plugins/content/vote/tmpl/rating.php on line 45
Summary of Changes
Define $rating_count
Testing Instructions
Create a Blog item menu, create some article for the blog. Enable Show Voting in the blog menu item.
Try to open in frontend the blog and see the php error log:
Patch and test again
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Looking at this, is voting on a blog actually even needed? I see no way to "vote" on the actual blog view... I can see where to vote on the articles (when viewing the article) but I see no way to enable people to vote on a blog view.
The stars are not clickable, and there is no other way to vote on the blog?
you cannot vote on a blog - correct
you should be able to see the results though
Results of what?
I see stars under blog heading which show and can't be voted on and also the result stars from an article
So why do stars appear in the blog heading?
Sent from my iPhone
On 23 May 2017, at 12:19, Brian Teeman notifications@github.com wrote:
you cannot vote on a blog - correct
you should be able to see the results though—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
the results of the votes that people have made on the article view
I have one article in my blog view, but if you enable voting on the blog menu item you get a strange set of stars ABOVE the article
It's that set of stars that can be changed/voted on - I'm not sure why you are allowed to have voting enabled there...
Sent from my iPhone
On 23 May 2017, at 12:28, Brian Teeman notifications@github.com wrote:
the results of the votes that people have made on the article view
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
here is my full page after creating a blog view, with a single article, and enabling Show Voting on the MENU ITEM for the blog (as this PR says to do)
What Im confused about is that set of stars under the error message. Im guessing that the reason you are getting an error message is that Voting on a BLOG VIEW itself is "not a thing" (as there is also no way to register my vote, and what then am I actually voting on!?) .
The vote stars for the ARTICLE are shown, this is correct, and then if I click into the article I see how I can vote for that article.
But no where can I see the purpose, or way to vote on the actual Blog View itself (under the error).
Im guessing the reason we get a PHP warning/error there is because this simply should not be showing voting stars in that location!
NO!
In your Blog View, ABOVE the "Blog Article" title I see 5 stars in my install. Thats where the error message shows too.
Separate issue but I'm fairly sure the fix for that is going to be checking the full context and not just if its first part is for com_content.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16204.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Im sorry but I object to the RTC.
Adding more error suppression is NOT the correct fix!
Separate issue but I'm fairly sure the fix for that is going to be checking the full context and not just if its first part is for com_content.
Yes, the correct fix is
if ($context=='com_content.categories')
{
return;
}before the $rating = line, and then remove the error suppressors...
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-23 13:43:29 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 5529fc6
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16204.