? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
22 May 2017

Pull Request for Issue #16112

Summary of Changes

Joomla does not have to use multibyte mb_ or utf8_ functions to parsing UTF-8 input.

Testing Instructions

Expected result

All works as expected and parsing is faster.

Actual result

Parsing is slow.

Documentation Changes Required

No

avatar csthomas csthomas - open - 22 May 2017
avatar csthomas csthomas - change - 22 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2017
Category Libraries Unit Tests
avatar lynnfredricks
lynnfredricks - comment - 23 May 2017

#16112
@franz-wohlkoenig I just tested with 3.7.2 and execution time is not improved enough. Error has changed through:
/libraries/vendor/joomla/string/src/phputf8/mbstring/core.php on line 94

avatar csthomas
csthomas - comment - 24 May 2017

@lynnfredricks There is some misunderstanding. You said that you tested J3.7.2 and it is still slow, but IMO you have not tested it with current patch.

TEST INSTRUCTION

To test with current patch you can do:

  1. Create a copy of your original file in libraries/joomla/filter/input.php

  2. Download a file from https://raw.githubusercontent.com/csthomas/joomla-cms/1532e1156e6aba108af4fe649e6ffece4b4a10f8/libraries/joomla/filter/input.php

  3. Save downloaded file to your joomla folder, by replacing libraries/joomla/filter/input.php

  4. Now you can start the tests.

  5. After tests you can revert changes

The other way is to install fresh joomla from my branch:

  1. Download and install Joomla from https://github.com/csthomas/joomla-cms/archive/fixfilter.zip
  2. Add article and test.

Or

  1. To your current installed joomla 3.7.2 install component com_patchtester from:
    https://github.com/joomla-extensions/patchtester/releases/tag/2.0.1
  2. Apply patch with the same title as this PR or search by id 16201
  3. After this patch will be applied then you can start the tests.
  4. After tests you can revert changes in the component and uninstall com_patchtester
avatar infograf768
infograf768 - comment - 24 May 2017

I have tested this item successfully on 1532e11

This is spectacular!

Logged as a manager with the said article to which I added some utf8 in pagebreak.

Before patch: 270sec

After patch: between 15 and 20 sec depending if reload is included!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16201.

avatar infograf768 infograf768 - test_item - 24 May 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 24 May 2017

I have tested this item successfully on 1532e11

Patch ok for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16201.

avatar AlexRed AlexRed - test_item - 24 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 24 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 May 2017

RTC after two successful tests.

avatar lynnfredricks
lynnfredricks - comment - 24 May 2017

@csthomas Thank you for the instructions and help! I can confirm that I was able to both duplicate the existing article and also update / replace the text of the existing long article.

avatar rdeutz rdeutz - change - 24 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-24 20:10:14
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 24 May 2017
avatar rdeutz rdeutz - merge - 24 May 2017

Add a Comment

Login with GitHub to post a comment