User tests: Successful: Unsuccessful:
Pull Request for Issue #16112
Joomla does not have to use multibyte mb_
or utf8_
functions to parsing UTF-8 input.
All works as expected and parsing is faster.
Parsing is slow.
No
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries Unit Tests |
@lynnfredricks There is some misunderstanding. You said that you tested J3.7.2 and it is still slow, but IMO you have not tested it with current patch.
To test with current patch you can do:
Create a copy of your original file in libraries/joomla/filter/input.php
Download a file from https://raw.githubusercontent.com/csthomas/joomla-cms/1532e1156e6aba108af4fe649e6ffece4b4a10f8/libraries/joomla/filter/input.php
Save downloaded file to your joomla folder, by replacing libraries/joomla/filter/input.php
Now you can start the tests.
After tests you can revert changes
The other way is to install fresh joomla from my branch:
https://github.com/csthomas/joomla-cms/archive/fixfilter.zip
Or
com_patchtester
from:revert
changes in the component and uninstall com_patchtester
I have tested this item
This is spectacular!
Logged as a manager with the said article to which I added some utf8 in pagebreak.
Before patch: 270sec
After patch: between 15 and 20 sec depending if reload is included!
I have tested this item
Patch ok for me.
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 20:10:14 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
#16112
@franz-wohlkoenig I just tested with 3.7.2 and execution time is not improved enough. Error has changed through:
/libraries/vendor/joomla/string/src/phputf8/mbstring/core.php on line 94